584193 - fix print preview for 130078

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

This is roc's patch that I have scavenged.

Comment 2

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

Comment on attachment 462521 [details] [diff] [review]
patch

I'm atm on OSX so couldn't test printpreview. But the changes look
reasonable.

Comment 3

[Timothy Nikkel (:tnikkel)]

I've done basic tests of print and print preview on Linux and Windows with this patch + 130078.

Comment 4

[Timothy Nikkel (:tnikkel)]

Landed
http://hg.mozilla.org/mozilla-central/rev/86e8ec17e532

but backed out due to bug 585496. I guess I forgot to test this without 130078.
http://hg.mozilla.org/mozilla-central/rev/682eee29d90d
http://hg.mozilla.org/mozilla-central/rev/1831e8e87545

Comment 5

[Timothy Nikkel (:tnikkel)]

Is it worth spending any time trying to figure out why this doesn't work without 130078, or should we just land this at the same time as 130078?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The latter I guess

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm using an hourly build with 130078 relanded, and I can print preview pages just fine.

Is this still a bug for other people?

Comment 8

[Timothy Nikkel (:tnikkel)]

This bug landed at the same time as bug 130078. I haven't got around to marking all the bugs that landed with 130078 fixed yet.

Comment 9

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/0886ad6e6aaa