584330 - Dropmarkers don't appear correctly under Linux

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Bill Gianopoulos [:WG9s]]

Attachment: screenshot

The utilities menu button in the add-ons manager seems to display an unpressed and pressed button next to each other (at least under fedora 12 using gnome).

See attached screenshot.

Presumably this should look more like it does under Windows.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Shall we take care of it on bug 584006?

Comment 2

[Bill Gianopoulos [:WG9s]]

Well, as it turns out, comparing the page between Windows an Linux, this is NOT the only Linux issue.  Everyplace where on the page in Windows there is a dropmarker, it is absent on the page under Linux.

This is with a fresh profile and default theme.

Also the sort column direction indicator is absent.

Comment 3

[Dave Townsend [:mossop]]

Actually yes let's just cover the button in bug 584330 and use this for the dropmarkers issue.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #3)
> Actually yes let's just cover the button in bug 584330 and use this for the
> dropmarkers issue.

I'm sure you meant bug 584006.

Comment 6

[Bill Gianopoulos [:WG9s]]

Somehow having a bug confirmed as a blocker, but the status being unconfirmed didn't make a great deal of sense.

Comment 7

[Dmitry Medvinsky]

Attachment: Fix for Linux

I was able to get it properly looking under GNU/Linux, by using multiple backgrounds instead of list-style-image. You can see the properties on the screenshot I've attached in the Firebug window.

Haven't tested in under other OSs though, because at the moment I don't have an access to any. Also, I'm not sure this is a fix to apply, more like a hack, but, whatever.

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to comment #7)
> Created attachment 471467 [details]
> Fix for Linux
> 
> I was able to get it properly looking under GNU/Linux, by using multiple
> backgrounds instead of list-style-image. You can see the properties on the
> screenshot I've attached in the Firebug window.
> 
> Haven't tested in under other OSs though, because at the moment I don't have an
> access to any. Also, I'm not sure this is a fix to apply, more like a hack,
> but, whatever.

I can work that up into a patch for the gnomestripe theme.

However, it only fixes 1/2 of the issue.  The sort arrows on the Name and Last Updated column headers to show which it is sorted by and the direction of the sort do not show up either.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

The patch in bug 584006 fixes it for the utilities button (although it hasn't landed yet). It does so by only setting list-style-image to the .button-icon class (which seems like a more correct fix). ie:

button .button-icon {
  list-style-image: url(...);
}

The same strategy should work for the sort buttons too.

Comment 10

[Dave Townsend [:mossop]]

Fixed by bug 601022, file any remaining issues separately

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101125 Firefox/4.0b8pre ID:20101125030318