Closed Bug 584551 Opened 11 years ago Closed 11 years ago

XPCCallContext enters requests in the wrong order

Categories

(Core :: XPConnect, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta3+

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Whiteboard: [4b3] fixed-in-tracemonkey)

Attachments

(1 file)

Currently, XPCCallContext::Init enters the request on the new context before pushing it onto the context stack. Pushing a context onto the context stack causes us to set aside the stack chain on it, forcing us to enter a request on it. If the old context was previously in a request, however, this breaks the stack-based discipline that bug 552266 forces on us. In order to avoid this, we need to reverse the order of operations.
Attached patch Proposed fixSplinter Review
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #462987 - Flags: review?(igor)
Attachment #462987 - Flags: review?(igor) → review+
Blocks: 584673
Blocks: 584057
blocking2.0: --- → beta3+
Whiteboard: [4b3]
http://hg.mozilla.org/mozilla-central/rev/def9a9e3393a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
http://hg.mozilla.org/tracemonkey/rev/a4c2d83e4dc9
Whiteboard: [4b3] → [4b3] fixed-in-tracemonkey
Verified that this doesn't crash when I drag tabs to the desktop - for some reason I lost the ability to drop tabs on the desktop for a moment, but it seems to be working now.
You need to log in before you can comment on or make changes to this bug.