58464 - editusers.cgi has hard-coded regex for logins

Status: VERIFIED DUPLICATE of bug 32971

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Ken Bandes]

Bugzilla allows the admin to set a regular expression for logins (emailregexp).
However, on line 378 in editusers.cgi, the following line appears:
    unless ($user =~ /^[^\@]+\@[^\@]+$/) {

I've changed this locally to:
    my $emailregexp = Param('emailregexp');
    unless ($user =~ /$emailregexp/) {

I didn't use the 'o' option in case the parameter changes, but I might be wrong 
about that.

Comment 1

[Dave Miller [:justdave]]

I was going to say this really should be a 2.12, and I went to actually put this 
into a patch file and discovered this has already been fixed.  cvblame points to 
editusers.cgi v1.10 which checked in a patch that was submitted on bug 32971.


*** This bug has been marked as a duplicate of 32971 ***

Comment 2

[Matthew Tuck [:CodeMachine]]

V.

Comment 3

[Dave Miller [:justdave]]

moving to Bugzilla product
reassign to default owner/qa for INVALID/WONTFIX/WORKSFORME/DUPLICATE