584679 - Release notes link in update snippets should support beta periods

Status: RESOLVED FIXED

(Mozilla Messaging Graveyard :: Release Engineering, defect)

Description

[Mark Banner (:standard8)]

We keep getting complaints about this every time we do a beta period on a maintenance release, so it is time we should do something about it.

The update snippets contain a URL that points to the release notes for the final release e.g.

http://www.mozillamessaging.com/%locale%/thunderbird/3.1.2/releasenotes/

So when we push to beta channel, the person gets a link to "View more information about this update" and this is then 404 and they get confused.

The code is at: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/tools/patcher-configs/moz192-thunderbird-branch-patcher2.cfg&rev=1.15&mark=14

I assume the release patching code is the bit that updates the version.

Could we change this to a live url, so that we can redirect to the beta pages during the beta period and then to the actual release once we've released?

For its Help -> Release Notes menu option, Thunderbird currently uses:

http://live.mozillamessaging.com/%APP%/releasenotes?locale=%LOCALE%&version=%VERSION%&os=%OS%&buildid=%APPBUILDID%

Could we use something like:

http://live.mozillamessaging.com/thunderbird/releasenotes?locale=%locale%&version=3.1.2

It looks like we can't use OS or buildid parameters as Thunderbird doesn't support in-app replacements for this url - the %locale% is replaced by the patcher tool or aus.

Comment 1

[Philippe M. Chiasson (:gozer)]

(In reply to comment #0)
> We keep getting complaints about this every time we do a beta period on a
> maintenance release, so it is time we should do something about it.
< [...]
> 
> Could we use something like:
> 
> http://live.mozillamessaging.com/thunderbird/releasenotes?locale=%locale%&version=3.1.2

Absolutely!

> It looks like we can't use OS or buildid parameters as Thunderbird doesn't
> support in-app replacements for this url - the %locale% is replaced by the
> patcher tool or aus.

Looking at the patcher source in MozAUSLib.pm, looks like it can substibute %platform% too, but not buildid. So might want to at least include that platform, if only for tracking.

Comment 3

[Mark Banner (:standard8)]

gozer: ping, can you get this fixed for the next please?

Comment 4

[Philippe M. Chiasson (:gozer)]

Attachment: Update our existing patcher configs to use the new URLs

Comment 5

[Philippe M. Chiasson (:gozer)]

Attachment: [checked in] Update our existing patcher configs to use the new URLs v2

Comment 6

[Philippe M. Chiasson (:gozer)]

Attachment: [checked-in] Update release configuration to specify our new detail URL

Comment 7

[Philippe M. Chiasson (:gozer)]

Attachment: Add %buildid% substitution to patcher in detail urls

We'd like our detail urls in update offers to include the buildid, and currently, patcher doesn't support %buildid% substitution in these urls.

Comment 8

[Philippe M. Chiasson (:gozer)]

Attachment: Add %platform% substitution to patcher in detail urls

Sorry, wrong patch. s/buildid/platform/ in the previous comment. We want *platform* in the detail url.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 470843 [details] [diff] [review]
[checked in] Update our existing patcher configs to use the new URLs v2

r=Standard8 (though I'm also happy for a non-%platform% version if we don't get the platform patch in for next time we need this).

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 470844 [details] [diff] [review]
[checked-in] Update release configuration to specify our new detail URL

r=Standard8 (though I'm also happy for a non-%platform% version if we don't get the platform patch in for next time we need this).

Comment 11

[[e-mail] (:bhearsum)]

Comment on attachment 470848 [details] [diff] [review]
Add %platform% substitution to patcher in detail urls

Seems fine. You're going to have to deal with an UPDATE_PACKAGING tag change, though.

I'm OK with just moving the UPDATE_PACKAGING_R12 tag on patcher2.pl to include this. Nick, what do you think?

Comment 12

[Philippe M. Chiasson (:gozer)]

Comment on attachment 470843 [details] [diff] [review]
[checked in] Update our existing patcher configs to use the new URLs v2

Checking in moz19-thunderbird-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz19-thunderbird-branch-patcher2.cfg,v  <--  moz19-thunderbird-branch-patcher2.cfg
new revision: 1.28; previous revision: 1.27
done
Checking in moz192-thunderbird-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz192-thunderbird-branch-patcher2.cfg,v  <--  moz192-thunderbird-branch-patcher2.cfg
new revision: 1.17; previous revision: 1.16
done

Comment 13

[Philippe M. Chiasson (:gozer)]

Comment on attachment 470844 [details] [diff] [review]
[checked-in] Update release configuration to specify our new detail URL

comparing with ssh://hg.mozilla.org/build/buildbot-configs
searching for changes
changeset:   2929:9188c151ca2e
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Wed Sep 01 16:35:47 2010 -0400
summary:     Bug 584679 - Update release configuration to specify our new detail URL r=Standard8

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 470848 [details] [diff] [review]
Add %platform% substitution to patcher in detail urls

That's OK for a small change like this. One of these years we'll make it easier to version all changes properly by breaking out patcher (or whatever replaces it) from the main code base.

Comment 15

[Mark Banner (:standard8)]

So can we get the core patch landed into patcher please?

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 470848 [details] [diff] [review]
Add %platform% substitution to patcher in detail urls

Checking in patcher2.pl;
/cvsroot/mozilla/tools/patcher/patcher2.pl,v  <--  patcher2.pl
new revision: 1.40; previous revision: 1.39
done

cvs tag UPDATE_PACKAGING_R12 patcher2.pl
W patcher2.pl : UPDATE_PACKAGING_R12 already exists on version 1.39 : NOT MOVING tag to version 1.40

cvs tag -F UPDATE_PACKAGING_R12 patcher2.pl
T patcher2.pl

Comment 17

[Philippe M. Chiasson (:gozer)]

Reminder: We need to update our release configuration to UPDATE_PACKAGING_R12 if we want to benefit from this.

Comment 18

[Philippe M. Chiasson (:gozer)]

changeset:   3064:6217ca5c40ef
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Mon Oct 04 13:15:30 2010 -0400
summary:     Bug 584679 - Update to UPDATE_PACKAGING_R12 for patcher to expand %platform% in snippets