Closed Bug 584967 Opened 15 years ago Closed 15 years ago

mark deprecated dom interfaces and methods with [deprecated]

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b12

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 2 obsolete files)

For checkin
3.31 KB, patch
Details | Diff | Splinter Review
We have a way to mark interfaces and methods as deprecated which some compilers are able to use to complain about deprecation. This bug is for sprinkling that marker into dom/content idl files. Please note that at this time we only properly trigger these compile time warnings with msvc (bug 584953 covers the fixing the gcc side).
Attached patch patch (obsolete) — — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #463464 - Flags: review?(Olli.Pettay)
Comment on attachment 463464 [details] [diff] [review] patch >+++ b/dom/interfaces/canvas/nsICanvasRenderingContextWebGL.idl I don't know about this. Ask Vlad.
Attachment #463464 - Flags: review?(Olli.Pettay) → review+
Attachment #463464 - Flags: review?(vladimir)
Attached patch smaug's portion (obsolete) — — Splinter Review
Attachment #463464 - Attachment is obsolete: true
Attachment #495404 - Flags: review+
Attachment #495404 - Flags: approval2.0?
Attachment #463464 - Flags: review?(vladimir)
Attachment #495404 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/af87fa0a3052
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Backed out because the patch broke our builds: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296673220.1296673556.12608.gz&fulltext=1 http://hg.mozilla.org/mozilla-central/rev/1f1e236c45f4
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla2.0b12 → ---
Attached patch For checkin — — Splinter Review
This patch only adds deprecated to interfaces. timeless told me that the parser needs fixing before it can handle deprecated on methods.
Depends on: 578478
No longer depends on: 584960
Attachment #495404 - Attachment is obsolete: true
Comment on attachment 509493 [details] [diff] [review] For checkin This built successfully on try.
Attachment #509493 - Attachment description: Partial patch → For checkin
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/2a73f1addf2f Please file another bug for the methods case.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
I backed this patch as part of this pushlog <http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=7e12e3e16e6c> because of the oranges it caused <http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296852850.1296854923.2345.gz&fulltext=1>. I'm not sure which one of the bugs was at fault, so I just backed them all out. The assignee needs to investigate and make sure that his patch has not been the culprit, and then re-add checkin-needed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Relanded all but one of the patches in that push. For this bug, that's: http://hg.mozilla.org/mozilla-central/rev/eb6683a406b1
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: