584998 - mark deprecated xpcom interfaces and methods with [deprecated]

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[timeless]

We have a way to mark interfaces and methods as deprecated which some compilers
are able to use to complain about deprecation. This bug is for sprinkling that
marker into caps xpcom files.

Please note that at this time we only properly trigger these compile time
warnings with msvc (bug 584953 covers the fixing the gcc side).

Comment 1

[timeless]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 463485 [details] [diff] [review]
patch

I don't think this works the way you want, unfortunately. I tried to add [deprecated] to a few XPCOM component methods, and MSVC warns at the time you *implement* the API, not just when you use it, which leads to undesirable warning-spam.

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> I don't think this works the way you want, unfortunately. I tried to add
> [deprecated] to a few XPCOM component methods, and MSVC warns at the time you
> *implement* the API, not just when you use it, which leads to undesirable
> warning-spam.
Actually, it warns at the time you declare the method (which may be when you implement it).  You can disable the warning for small areas where you know you are hitting it but it's OK:
http://msdn.microsoft.com/en-us/library/ttcz0bys%28VS.80%29.aspx

And you can turn it back on by doing the same thing, but s/disable/default/

Comment 4

[Shawn Wilsher :sdwilsh]

For example, see attachment 510408 [details] [diff] [review]

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 6

[Andrew McCreight [:mccr8]]

nsITraceRefcnt and nsISupportsArray no longer exist.