Closed
Bug 585016
Opened 15 years ago
Closed 12 years ago
Invoke buildlist.py as a pymake native command
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: ted, Assigned: gps)
References
(Blocks 1 open bug)
Details
(Whiteboard: [pymake])
Attachments
(1 file, 2 obsolete files)
|
12.42 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
We should invoke buildlist.py as a pymake native command to avoid the overhead of spawning a new Python interpreter every time we run it.
Whiteboard: [pymake]
| Assignee | ||
Comment 1•12 years ago
|
||
Now that we have mozbuild "action" modules, it makes sense to move
buildlist.py there. Patch should be relatively straightforward.
https://tbpl.mozilla.org/?tree=Try&rev=73e125831a42
Attachment #814196 -
Flags: review?(mshal)
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → gps
| Assignee | ||
Comment 2•12 years ago
|
||
Turns out JarMaker.py was importing buildlist. I fixed the import and
removed some unused imports.
https://tbpl.mozilla.org/?tree=Try&rev=6cf1d3f0ca2e
Attachment #814216 -
Flags: review?(mshal)
| Assignee | ||
Updated•12 years ago
|
Attachment #814196 -
Attachment is obsolete: true
Attachment #814196 -
Flags: review?(mshal)
| Assignee | ||
Comment 3•12 years ago
|
||
Turns out you need a main() method in pymake commands.
https://tbpl.mozilla.org/?tree=Try&rev=99a26dff5939
Attachment #814316 -
Flags: review?(mshal)
| Assignee | ||
Updated•12 years ago
|
Attachment #814216 -
Attachment is obsolete: true
Attachment #814216 -
Flags: review?(mshal)
Comment 4•12 years ago
|
||
Comment on attachment 814316 [details] [diff] [review]
Move buildlist.py to a mozbuild action
Looks good!
Attachment #814316 -
Flags: review?(mshal) → review+
| Assignee | ||
Comment 5•12 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite-
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•