Closed Bug 585016 Opened 13 years ago Closed 10 years ago

Invoke buildlist.py as a pymake native command

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: ted, Assigned: gps)

References

(Blocks 1 open bug)

Details

(Whiteboard: [pymake])

Attachments

(1 file, 2 obsolete files)

Move buildlist.py to a mozbuild action
12.42 KB, patch
mshal
: review+
Details | Diff | Splinter Review 
We should invoke buildlist.py as a pymake native command to avoid the overhead of spawning a new Python interpreter every time we run it.
Now that we have mozbuild "action" modules, it makes sense to move
buildlist.py there. Patch should be relatively straightforward.

https://tbpl.mozilla.org/?tree=Try&rev=73e125831a42
Attachment #814196 - Flags: review?(mshal)
Assignee: nobody → gps
Turns out JarMaker.py was importing buildlist. I fixed the import and
removed some unused imports.

https://tbpl.mozilla.org/?tree=Try&rev=6cf1d3f0ca2e
Attachment #814216 - Flags: review?(mshal)
Attachment #814196 - Attachment is obsolete: true
Attachment #814196 - Flags: review?(mshal)
Turns out you need a main() method in pymake commands.

https://tbpl.mozilla.org/?tree=Try&rev=99a26dff5939
Attachment #814316 - Flags: review?(mshal)
Attachment #814216 - Attachment is obsolete: true
Attachment #814216 - Flags: review?(mshal)
Blocks: 924330
Blocks: 924331
Comment on attachment 814316 [details] [diff] [review]
Move buildlist.py to a mozbuild action

Looks good!
Attachment #814316 - Flags: review?(mshal) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/05693539cfe6
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/05693539cfe6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Blocks: 926043
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.