Closed Bug 924331 Opened 6 years ago Closed 6 years ago

Move config/utils.py into mozbuild package

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

config/utils.py should be moved into mozbuild.utils or something.
Depends on: 585016
Pretty basic code migration. I took the opportunity to fix the
indenting, add some punctuation to comments, etc.

https://tbpl.mozilla.org/?tree=Try&rev=fc3e797d01b0
Attachment #814328 - Flags: review?(mshal)
Assignee: nobody → gps
Comment on attachment 814328 [details] [diff] [review]
Move config/utils.py into mozbuild

># HG changeset patch
># User Gregory Szorc <gps@mozilla.com>
># Date 1381225528 -7200
>#      Tue Oct 08 11:45:28 2013 +0200
># Node ID 51a74bf13f36208325f898e7190385611a9bfdb3
># Parent  abb7e2fa905cd57a86241e5b6144d52ccb62dee6
>Bug 924331 - Move config/utils.py into mozbuild
>
>diff --git a/config/JarMaker.py b/config/JarMaker.py
>--- a/config/JarMaker.py
>+++ b/config/JarMaker.py
>@@ -12,17 +12,21 @@ import os
> import os.path
> import errno
> import re
> import logging
> from time import localtime
> from MozZipFile import ZipFile
> from cStringIO import StringIO
> 
>-from utils import pushback_iter, lockFile
>+from mozbuild.util import (
>+    lock_file,
>+    PushbackIter,
>+)

So pushback_iter goes from underscores to CamelCase, and lockFile goes from CamelCase to underscores? :)
Attachment #814328 - Flags: review?(mshal) → review+
classes are CamelCase functions are under_scores.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2c4921ff7c
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/4a2c4921ff7c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
Depends on: 1535948
You need to log in before you can comment on or make changes to this bug.