Closed Bug 585137 Opened 13 years ago Closed 13 years ago

Make nsICSSRule::Clone return the cloned value directly.

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b4

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch v1
22.34 KB, patch
bzbarsky
: review+
dbaron
: approval2.0+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
None of the implementations of nsICSSRule::Clone can actually fail, thanks to infallible new.
Flags: in-testsuite-
Attachment #463624 - Flags: review?(bzbarsky)
Comment on attachment 463624 [details] [diff] [review]
Patch v1

r=bzbarsky
Attachment #463624 - Flags: review?(bzbarsky) → review+
Attachment #463624 - Flags: approval2.0?
Attachment #463624 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
patching file content/xul/content/src/nsXULElement.cpp
Hunk #1 FAILED at 1929
Hunk #2 FAILED at 2318
2 out of 2 hunks FAILED -- saving rejects to file content/xul/content/src/nsXULElement.cpp.rej
patching file layout/style/nsCSSStyleRule.cpp
Hunk #1 FAILED at 1305
1 out of 2 hunks FAILED -- saving rejects to file layout/style/nsCSSStyleRule.cpp.rej
patching file layout/style/nsICSSStyleRule.h
Hunk #1 FAILED at 286
1 out of 1 hunks FAILED -- saving rejects to file layout/style/nsICSSStyleRule.h.rej
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/e9a04e8f25fd

(It required a little merging in nsXULElement and a new IID for nsICSSStyleRule.)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in before you can comment on or make changes to this bug.