Closed Bug 585163 Opened 14 years ago Closed 13 years ago

[d2d] TEST-UNEXPECTED-FAIL | svg/text-scale-01.svg

Categories

(Core :: Graphics, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

Looks like the geometry we send to d2d is different in the cases where we get different pixels. I'm not yet sure why.
The values that get passed into D2D are different:

font_matrix	{xx=100.00000149011612 ...}
ctm	{xx=1.0000000474974513 ...}	

vs.

font_matrix	{xx=100.00000000000000  ...}
ctm	{xx=1.0000000000000000 ...}

Not exactly sure why.
The inaccurate values for font_matrix come from converting 6/60 into a float and then treating it as a double. I see two possible fixes: we could add a AppUnitsToDoubleCSSPixels or AppUnitsToFloat64CSSPixels that would do the division at higher precision or we could switch the test to use sizes that have an exact representation in floating point instead of using .1 which does not.
Or we could do something like gfxContext::NudgeCurrentMatrixToIntegers
Assignee: nobody → jmuizelaar
Attachment #463842 - Flags: review?(roc)
This landed in August 2010:

http://hg.mozilla.org/mozilla-central/rev/237c0f3abaf6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.