585164 - AppTabs' visual glitches (wrong height; visible lines, that shouldn't be shown).

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Please Ignore This Troll (Account Disabled)]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100806 Minefield/3.7a5pre YB/3.5.1
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100806 Firefox/4.0b4pre

AppTabs are customized bad. Two things I've noticed:
a). wrong height (it's smaller than regular tab's height)

b). visible lines under FavIcon, that shouldn't be shown (they are hidden for regular tabs)

p.s.: since these 2 bugs are related to the neighboring code parts, I filed 1 bug for both of them.

Reproducible: Always

Steps to Reproduce:
a). 1. Open 1 tab on the tab bar.
2. Make it into AppTab.

b). 1. Make some tabs into AppTabs and take a look under them, and compare it to the space under regular tabs.
Actual Results:  
a). Compare the two states (regular tab and AppTab) and watch the tabbar losing it's height too due to AppTabs having smaller height, than regular tabs.

b). There are visible lines (borders) under AppTabs.

Expected Results:  
a). The states shouldn't differ, AppTab's height should be equal to the regular tab's.

b). The borders should be hidden behind a plain toolbar space at the bottom of the tab bar.

I don't remember how it looks on Win 7 with aero theme, but I know that this bug is present for XP SP3 with classic theme (no themes, no personas).

Comment 2

[Please Ignore This Troll (Account Disabled)]

Since Mike said they won't reopen bug 579683 and suggested me to create a new one - I simply changed the state of this one.

The bug is alive.

I don't know for which reasons bug 579683 has status resolved fixed, I think it's a corruption in mozdev team, since I pointed, that the bug is alive after the patch has landed.

I tried on a new profile the latest nightly build and the bug is still there.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Hey Shorlander; when you get a chance, can you check the image in this bug and see if you agree, and indicate if there are already bugs on file to address the issues?

Comment 4

[Stephen Horlander [:shorlander]]

I am not seeing the problems described in the STR from comment 0 on the latest nightly.

Comment 5

[Please Ignore This Troll (Account Disabled)]

OMFG.
Ok, once again step by step:
1. I've got Win7 with aero enabled.
2. I create a brand new profile with latest nightly build.
3. I run Firefox and make it open 2 similar tabs.
4. I pin one of them as apptab.
Look at what I get:
http://img688.imageshack.us/img688/6673/cleanprofile.png
Compare favicon's position for apptab and regular tab: in latest nightly apptab's favicon is 1px lower than regular tab's one. Zoom in the screenshot and just measure the position to get a proof.

5. I make 3rd copy of the tab and pin it as apptab, so I have 2 apptabs and 1 regular tabs.
6. I make middle apptab active
Look at what I get:
http://img215.imageshack.us/img215/1331/2similarapptabsand1tab.png
Zoom in the picture if needed and take a notice, that middle apptab's border is drawn with 1px over the navtoolbar, which doesn't happen when the active tab is not pinned as apptab (take a look at 1st screenshot for proof).

7. Close regular tab, so only 2 apptabs remain
Look at what I get:
http://img215.imageshack.us/img215/1097/2similarapptabs.png
Zoom in the picture if needed and compare this screenshot to the previous ones and watch tabbar to lose it's height and navbar to go a little bit upper.

Questions?

Comment 6

[Marco Bonardo [:mak]]

Attachment: 1 px too low

fwiw, I see a similar problem in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100914 Firefox/4.0b7pre
I have only 1 app tab (just created it) and it's blending 1 px too low in the toolbar.

Comment 7

[Please Ignore This Troll (Account Disabled)]

(In reply to comment #6)
> Created attachment 475471 [details]
> 1 px too low
> 
> fwiw, I see a similar problem in Mozilla/5.0 (Windows NT 6.1; WOW64;
> rv:2.0b7pre) Gecko/20100914 Firefox/4.0b7pre
> I have only 1 app tab (just created it) and it's blending 1 px too low in the
> toolbar.

Try to open 2 similar tabs (with the same favicons) and 1 of them pin as apptab and compare favicon position.

P.s.: changed platform and os specifics for this bug.

Comment 8

[hjalte]

Attachment: Close-up of app tabs shrinking and drawing into into the navbar by 1px

These probelms exist for me, but I'm not sure they've been properly shown in this bug.  I would recommend changing the bug name to something more descriptive like "App tabs draw into and shrink navbar by one pixel."

I think that the issue of the favicons for app tabs drawing one pixel too low compared to regular tabs (which I will make a screenshot of) is probably a side effect of the app tabs drawing 1 pixel too far down overall.

Comment 9

[hjalte]

Attachment: Close-up of app tabs' favicons being 1px too low

Comment 10

[Please Ignore This Troll (Account Disabled)]

I don't confirm this bug.

Comment 11

[Lain_13]

I can confirm this bug on latest nightly.
Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b7pre) Gecko/20100923 Firefox/4.0b7pre
(Tested on Windows Vista, as you can see from UA)

All 3 parts are here:
1. Favicon on app-tabs 1px lower then on usual tabs.
2. Bottom border of app-tabs 1px lower then bottom border of usual tabs.
3. When all usual tabs are closed tab-bar became 1px thinner.

Will add my screenshots in a few minuts.

Comment 12

[Lain_13]

Attachment: Example of wrong position of Favicon on App-Tab

Comment 13

[Lain_13]

Attachment: Wrong position of bottom border

Comment 14

[Lain_13]

Attachment: Wrong height of Tab-Bar without tabs

I made slice on the right side to show height of tab-bar with usual tab on the same images.

Comment 15

[Mikhail Kalashnik]

https://bugzilla.mozilla.org/show_bug.cgi?id=595285 - maybe similar bug

Comment 16

[Please Ignore This Troll (Account Disabled)]

(In reply to comment #15)
> https://bugzilla.mozilla.org/show_bug.cgi?id=595285 - maybe similar bug

no, it's not.
Не запутывай людей.

Comment 17

[hjalte]

Latest hourly with patch from Bug 597592 does not have any of these problems any longer.

Comment 18

[Please Ignore This Troll (Account Disabled)]

(In reply to comment #17)
> Latest hourly with patch from Bug 597592 does not have any of these problems
> any longer.

Some problems are still there: tab-bar's height is still bouncing if [for example] you have 1 tab and you click to pin it as app-tab, or vice-versa.

Comment 19

[Lain_13]

On Linux version it looks even worse because tab-bar's height changes not only when you pin/unpin single tab but also when you open _second_ regular tab. For example, if I have only 1 pinned tab and will open 1 new regular tab tab-bar will receive +1px to height. If I will open one more regular tab tab-bar will receive one more +1px to height and will have +2px in sum!

Comment 20

[hjalte]

My bad, you're right.

(In reply to comment #18)
> (In reply to comment #17)
> > Latest hourly with patch from Bug 597592 does not have any of these problems
> > any longer.
> 
> Some problems are still there: tab-bar's height is still bouncing if [for
> example] you have 1 tab and you click to pin it as app-tab, or vice-versa.

Comment 21

[Please Ignore This Troll (Account Disabled)]

(In reply to comment #20)
> 
> My bad, you're right.

For Win 7 Aero, with latest Fx nightly and no personas/themes applied to it, this short style fixes the last issue with different tabbar's height in different cases:

#TabsToolbar:not(:-moz-lwtheme) { min-height: 24px !important; }

Add same rules with customize values for Linux and Mac to the corresponding files and regard it as a patch to fix this bug.

Comment 22

[Lain_13]

On my Linux system second change to size were resolved by changing 24 on 25 from Paul's style. So, there is additional bug in skin for Linux. Probably inactive tabs are higher then active (I didn't check this, just guessing).

Comment 23

[bogas04]

I can reproduce changing height of apptab

Comment 24

[bogas04]

Attachment: Wrong height when nav bar is hidden

Comment 25

[Lain_13]

#23: Can't reproduce on Linux as well. Looks like fixed for me.

Comment 26

[bogas04]

Well , then it is not for windows?

Comment 27

[Lain_13]

#26: Don't know about windows. However on Linux I can reproduce bug from your comment 24.

Also if you put tabs on the navigation toolbar or urlbar on the tabbar then you may notice that app-tabs "hovering". They not high enough to touch bottom of toolbar.

Comment 28

[Please Ignore This Troll (Account Disabled)]

The bug is also reproduced on XP and 7.

Comment 29

[bogas04]

yeah , so isnt this bug confirmed?

Comment 30

[Please Ignore This Troll (Account Disabled)]

(In reply to comment #29)
> yeah , so isnt this bug confirmed?

I can't mark a bug to be "new" instead of confirmed. And the ones who can - they don't care about my bugs (maybe even on purpose, but it doesn't matter). I've posted screenshots, other people also say they have this bug but no, it stays unconfirmed, though I even suggested a patch fixing this issue - but no one cares.

Comment 31

[bogas04]

we should spread this to forums ?

Comment 32

[bogas04]

This is indeed an important bug , but yeah it comes in theme fixes , so maybe it would be considered later on?

Comment 33

[Please Ignore This Troll (Account Disabled)]

Whatever, man. I have installed my own style to fix this problem and it works great for me, so I'm pretty confident with, just wanted this bug to be fixed for all.

Comment 34

[bogas04]

can you share your scripts to fix it? Even i want this fixed

Comment 35

[Please Ignore This Troll (Account Disabled)]

They had been posted already long ago in the comments to the bug 579683.
The fact is that there are 2 morons. One of them is Gayvin, who gave review+ to the patch that didn't fix the bug. The other moron is Gaywald, who marked that bug as resolved fixed, though it is not fixed even up to now, that's why I had to unmark this bug as a duplicate of that one.
The third moron is belztnebooth, who requested a proof that the bug was not fixed, and when I showed him proofpics with the bug still alive - he just shut about it. Then my account was banned.

So to fix the issue for Windows 7 Aero:
#TabsToolbar { min-height: 24px !important; }

For other OSes the value may differ.

Comment 36

[bogas04]

Thanks , oh , the story is really sad , it is ALIVE! Just follow the steps and u can reproduce it easily . :/

Comment 37

[Please Ignore This Troll (Account Disabled)]

The bug was silently fixed in the latest nightly. See? They do it silently. But, at last it is fixed now (at least for me and I'm on Win7 with Aero theme, asked Lain to post about Linux).

Comment 38

[bogas04]

Yeah , its fixed! :D

Comment 39

[Lain_13]

Actual state on linux:
1. Favicons on app-tabs 1px higher then on usual tabs.
2. Tab-bar with only 1 opened usual tab 1px thiner then with 2+ tabs (app-tabs doesn't matter).
3. When last tab closed and only app-tabs left tab-bar became +1px higher and then -1px - all content below from opened app-tab jumps.
4. When we have app-tabs and 1 regular tab switching to app-tab makes tab-bar 1px higher and switching back 1px thiner.

Comment 40

[Please Ignore This Troll (Account Disabled)]

(In reply to comment #38)
> Yeah , its fixed! :D

And my 4th account was banned just after that message.

(In reply to comment #39)

Well, my patch should fix that most of that issues for Linux too, if you tune the number in pixels, but as for windows (7 with aero) - all the issues have completely gone for me.

Comment 41

[Please Ignore This Troll (Account Disabled)]

Bad news: I just got this bug back for some time (I had 1 single tab and it was pinned), but after adding/closing some tabs the bug has gone once again. So I still suggest to add my style as a patch to the source code.