585264 - Tabbrowser should tell Gecko which tab is active and which isn't.

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Philip Chee]

Port the tabbrowser parts of Bug 343515 (need API for tabbrowsers to tell docshells they're visible/hidden)

Comment 1

[Philip Chee]

Attachment: Patch v1.0 straight port

Overheard in #seamonkey:
<KaiRo> wonders if someone could port the tabbrowser part of http://hg.mozilla.org/mozilla-central/rev/b7836c3a63db to our side.

This patch ports the Firefox tabbrowser changes and passes the tests in attachment 461367 [details] [diff] [review].

Comment 2

[[e-mail]]

Comment on attachment 463768 [details] [diff] [review]
Patch v1.0 straight port

>+              // We start our browsers out as inactive, and then maintain
>+              // activeness in the tab switcher.
>+              b.docShell.isActive = false;
>             }
> 
>             if (aFocusNewTab) {
>               var parentTab = this.selectedTab;
>               this.selectedTab = t;
>               this.mPreviousTab = parentTab;
>             }
>             else
Is it worth moving that line down here?

Comment 3

[Robert Kaiser]

(In reply to comment #1)
> This patch ports the Firefox tabbrowser changes and passes the tests in
> attachment 461367 [details] [diff] [review].

OK, just to make this clear, these are tests that landed and we run and fail now, right?

Comment 4

[Philip Chee]

Attachment: Patch v1.1 fix nit.

> Is it worth moving that line down here?
Moved. All tests still pass.

Obviously it would be good to land this patch before the tests land.

Comment 5

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/97bab6aae962