Port bug 648045 - Mark the active tab in minimized windows as inactive

RESOLVED FIXED in seamonkey2.7

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: neil, Assigned: neil)

Tracking

Trunk
seamonkey2.7
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.6 fixed)

Details

Attachments

(2 attachments)

Plus we can also hang the resizer updates off the new sizemodechange event.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #558424 - Flags: review?(iann_bugzilla)
Comment on attachment 558424 [details] [diff] [review]
Proposed patch

>+++ b/suite/browser/navigatorOverlay.xul
>   <broadcasterset id="navBroadcasters">
>     <broadcaster id="canGoBack"    disabled="true"/>
>     <broadcaster id="canGoForward" disabled="true"/>
>     <broadcaster id="canGoUp"      disabled="true"/>
>     <broadcaster id="Communicator:WorkMode"/>
>-    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowResizer();" checked="true"/>
>+    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowState();" checked="true"/>
Any advantage in having one attribute per line here?
Attachment #558424 - Flags: review?(iann_bugzilla) → review+
(In reply to Ian Neal from comment #2)
>(From update of attachment 558424 [details] [diff] [review])
>>-    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowResizer();" checked="true"/>
>>+    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowState();" checked="true"/>
>Any advantage in having one attribute per line here?
The oncommand attribute itself is over 80 characters, so I'd need to wrap it:
    <broadcaster id="cmd_viewtaskbar"
                 checked="true"
                 oncommand="goToggleToolbar('status-bar', 'cmd_viewtaskbar');
                            updateWindowState();"/>
Would that be acceptable?
(In reply to neil@parkwaycc.co.uk from comment #3)
> (In reply to Ian Neal from comment #2)
> >(From update of attachment 558424 [details] [diff] [review])
> >>-    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowResizer();" checked="true"/>
> >>+    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowState();" checked="true"/>
> >Any advantage in having one attribute per line here?
> The oncommand attribute itself is over 80 characters, so I'd need to wrap it:
>     <broadcaster id="cmd_viewtaskbar"
>                  checked="true"
>                  oncommand="goToggleToolbar('status-bar', 'cmd_viewtaskbar');
>                             updateWindowState();"/>
> Would that be acceptable?

That is fine.
Pushed changeset c35987a729f0 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Bah, I just realised that this makes no sense if we're not actually tracking inactive docshells in the first place...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The good news is that we were tracking the per-tab active state.
The bad news was that this was ignoring the minimised state.
This patch fixes that in a similar way to the window resizer.
Additionally, we were also not using the convenience method.
Note that unlike window resizer, active state defaults "wrongly",
so we need to reset it when creating a new tab.
Attachment #568870 - Flags: review?(iann_bugzilla)
Attachment #568870 - Flags: review?(iann_bugzilla) → review+
Pushed changeset 1ff1d44b5720 to comm-central.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Comment on attachment 568870 [details] [diff] [review]
Additional patch

The first patch was old enough to get an aurora uplift so this patch should land on aurora too.
Attachment #568870 - Flags: approval-comm-aurora?
Attachment #568870 - Flags: approval-comm-aurora? → approval-comm-aurora+
Keywords: checkin-needed
Whiteboard: [transplant changeset 1ff1d44b5720 to comm-aurora]
Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/96f9be89d243
Keywords: checkin-needed
Whiteboard: [transplant changeset 1ff1d44b5720 to comm-aurora]
Target Milestone: --- → seamonkey2.7
Blocks: 728096
Depends on: 648045
Depends on: 585264
You need to log in before you can comment on or make changes to this bug.