684805 - Port bug 648045 - Mark the active tab in minimized windows as inactive

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Plus we can also hang the resizer updates off the new sizemodechange event.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Ian Neal]

Comment on attachment 558424 [details] [diff] [review]
Proposed patch

>+++ b/suite/browser/navigatorOverlay.xul
>   <broadcasterset id="navBroadcasters">
>     <broadcaster id="canGoBack"    disabled="true"/>
>     <broadcaster id="canGoForward" disabled="true"/>
>     <broadcaster id="canGoUp"      disabled="true"/>
>     <broadcaster id="Communicator:WorkMode"/>
>-    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowResizer();" checked="true"/>
>+    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowState();" checked="true"/>
Any advantage in having one attribute per line here?

Comment 3

[[e-mail]]

(In reply to Ian Neal from comment #2)
>(From update of attachment 558424 [details] [diff] [review])
>>-    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowResizer();" checked="true"/>
>>+    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowState();" checked="true"/>
>Any advantage in having one attribute per line here?
The oncommand attribute itself is over 80 characters, so I'd need to wrap it:
    <broadcaster id="cmd_viewtaskbar"
                 checked="true"
                 oncommand="goToggleToolbar('status-bar', 'cmd_viewtaskbar');
                            updateWindowState();"/>
Would that be acceptable?

Comment 4

[Ian Neal]

(In reply to [e-mail] from comment #3)
> (In reply to Ian Neal from comment #2)
> >(From update of attachment 558424 [details] [diff] [review])
> >>-    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowResizer();" checked="true"/>
> >>+    <broadcaster id="cmd_viewtaskbar" oncommand="goToggleToolbar('status-bar','cmd_viewtaskbar'); updateWindowState();" checked="true"/>
> >Any advantage in having one attribute per line here?
> The oncommand attribute itself is over 80 characters, so I'd need to wrap it:
>     <broadcaster id="cmd_viewtaskbar"
>                  checked="true"
>                  oncommand="goToggleToolbar('status-bar', 'cmd_viewtaskbar');
>                             updateWindowState();"/>
> Would that be acceptable?

That is fine.

Comment 5

[[e-mail]]

Pushed changeset c35987a729f0 to comm-central.

Comment 6

[[e-mail]]

Bah, I just realised that this makes no sense if we're not actually tracking inactive docshells in the first place...

Comment 7

[[e-mail]]

Attachment: Additional patch

The good news is that we were tracking the per-tab active state.
The bad news was that this was ignoring the minimised state.
This patch fixes that in a similar way to the window resizer.
Additionally, we were also not using the convenience method.
Note that unlike window resizer, active state defaults "wrongly",
so we need to reset it when creating a new tab.

Comment 8

[[e-mail]]

Pushed changeset 1ff1d44b5720 to comm-central.

Comment 9

[[e-mail]]

Comment on attachment 568870 [details] [diff] [review]
Additional patch

The first patch was old enough to get an aurora uplift so this patch should land on aurora too.

Comment 10

[Philip Chee]

Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/96f9be89d243