Closed Bug 585285 Opened 11 years ago Closed 11 years ago

Make styling for type="menu-button" toolbarbuttons respect the toolbarbutton-1 class

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 4.0b5
Tracking Status
blocking2.0 --- final+

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
Our custom styling for primary toolbarbuttons depends on the toolbarbutton-1 class, except for type="menu-button", where we always impose the styling. This leads to inconsistent add-on toolbars such as the one in attachment 461527 [details].
Attachment #463777 - Flags: review?(mano)
Assignee: nobody → dao
Version: unspecified → Trunk
Attached patch patch (obsolete) — Splinter Review
updated to tip
Attachment #463777 - Attachment is obsolete: true
Attachment #466086 - Flags: review?(mano)
Attachment #466086 - Flags: review?(gavin.sharp)
Attachment #463777 - Flags: review?(mano)
blocking2.0: --- → ?
Attached patch patchSplinter Review
updated to tip
Attachment #466086 - Attachment is obsolete: true
Attachment #466977 - Flags: review?(mano)
Attachment #466977 - Flags: review?(gavin.sharp)
Attachment #466086 - Flags: review?(mano)
Attachment #466086 - Flags: review?(gavin.sharp)
Attachment #466977 - Flags: review?(gavin.sharp) → approval2.0?
Attachment #466977 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/ace3eeec242a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5
blocking2.0: ? → final+
Verified fixed Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre

Thank you!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.