585420 - Drop files from intl and restore nsCaseConversionImp2

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[timeless]

nsCaseConversionImp2 is unused, and a bunch of the files in intl are just slowing down the build

Comment 1

[timeless]

Attachment: patch

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Uh, you asked me to keep nsCaseConversionImp2 around https://bugzilla.mozilla.org/show_bug.cgi?id=575043#c8.  If you want to remove it nsICaseConversion should die too.

Comment 3

[timeless]

err. grumble. keeping it around meant keeping it accessible, which would have meant not removing the contract... :( i'll look into this later

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Bleh, I thought I left that in. :-(

Comment 5

[timeless]

ok. i've taken the time to put it back. we should actually fix this before 2.0 because it's important for extension consumers to be able to use it.

Comment 6

[timeless]

Attachment: restore nsCaseConversionImp2, add guards, drop stale bits

I'm asking for approval because bug 575043 broke our ability to enable extensions to use the same case behavior we have.

Comment 7

[Benjamin Smedberg]

Comment on attachment 492172 [details] [diff] [review]
restore nsCaseConversionImp2, add guards, drop stale bits

Clearing approval nom until reviews are complete.

Comment 8

[timeless]

Attachment: patch from my live tree

Comment 9

[Daniel Holbert [:dholbert]]

timeless: is this checkin-needed?

Comment 10

[Daniel Holbert [:dholbert]]

(ah, looks like it only *just* got approval, so you probably just haven't gotten a chance to flag it as checkin-needed yet.  In comment 9 I was only looking at the date on the patch, and I thought it might have been forgotten. sorry for breathing down your neck. :))

Comment 11

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/a72efacb1328