Closed Bug 585420 Opened 9 years ago Closed 9 years ago

Drop files from intl and restore nsCaseConversionImp2

Categories

(Core :: Internationalization, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 2 obsolete files)

nsCaseConversionImp2 is unused, and a bunch of the files in intl are just slowing down the build
Attached patch patch (obsolete) — Splinter Review
Assignee: smontagu → timeless
Status: NEW → ASSIGNED
Attachment #463901 - Flags: review?(smontagu)
Uh, you asked me to keep nsCaseConversionImp2 around https://bugzilla.mozilla.org/show_bug.cgi?id=575043#c8.  If you want to remove it nsICaseConversion should die too.
err. grumble. keeping it around meant keeping it accessible, which would have meant not removing the contract... :( i'll look into this later
Attachment #463901 - Flags: review?(smontagu)
ok. i've taken the time to put it back. we should actually fix this before 2.0 because it's important for extension consumers to be able to use it.
Summary: Drop files from intl including nsCaseConversionImp2 → Drop files from intl and restore nsCaseConversionImp2
I'm asking for approval because bug 575043 broke our ability to enable extensions to use the same case behavior we have.
Attachment #463901 - Attachment is obsolete: true
Attachment #492172 - Flags: review?
Attachment #492172 - Flags: approval2.0?
Attachment #492172 - Flags: review? → review?(smontagu)
Comment on attachment 492172 [details] [diff] [review]
restore nsCaseConversionImp2, add guards, drop stale bits

Clearing approval nom until reviews are complete.
Attachment #492172 - Flags: approval2.0?
Attachment #492172 - Attachment is obsolete: true
Attachment #494020 - Flags: review?(smontagu)
Attachment #492172 - Flags: review?(smontagu)
Attachment #494020 - Flags: review?(smontagu)
Attachment #494020 - Flags: review+
Attachment #494020 - Flags: approval2.0?
Attachment #494020 - Flags: approval2.0? → approval2.0+
Blocks: 622637
timeless: is this checkin-needed?
(ah, looks like it only *just* got approval, so you probably just haven't gotten a chance to flag it as checkin-needed yet.  In comment 9 I was only looking at the date on the patch, and I thought it might have been forgotten. sorry for breathing down your neck. :))
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/a72efacb1328
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.