Closed Bug 585420 Opened 11 years ago Closed 10 years ago
Drop files from intl and restore ns
Case Conversion Imp2
nsCaseConversionImp2 is unused, and a bunch of the files in intl are just slowing down the build
Assignee: smontagu → timeless
Status: NEW → ASSIGNED
Uh, you asked me to keep nsCaseConversionImp2 around https://bugzilla.mozilla.org/show_bug.cgi?id=575043#c8. If you want to remove it nsICaseConversion should die too.
err. grumble. keeping it around meant keeping it accessible, which would have meant not removing the contract... :( i'll look into this later
Bleh, I thought I left that in. :-(
ok. i've taken the time to put it back. we should actually fix this before 2.0 because it's important for extension consumers to be able to use it.
Summary: Drop files from intl including nsCaseConversionImp2 → Drop files from intl and restore nsCaseConversionImp2
I'm asking for approval because bug 575043 broke our ability to enable extensions to use the same case behavior we have.
Comment on attachment 492172 [details] [diff] [review] restore nsCaseConversionImp2, add guards, drop stale bits Clearing approval nom until reviews are complete.
timeless: is this checkin-needed?
(ah, looks like it only *just* got approval, so you probably just haven't gotten a chance to flag it as checkin-needed yet. In comment 9 I was only looking at the date on the patch, and I thought it might have been forgotten. sorry for breathing down your neck. :))
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.