Closed Bug 622637 Opened 14 years ago Closed 14 years ago

warning: ‘nsresult nsCaseConversionImp2Constructor(nsISupports*, const nsIID&, void**)’ defined but not used

Categories

(Core :: Internationalization, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Unassigned)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

When building nsI18nModule.cpp, I get this warning:
../../../mozilla/intl/build/../unicharutil/src/nsUcharUtilConstructors.h:79: warning: ‘nsresult nsCaseConversionImp2Constructor(nsISupports*, const nsIID&, void**)’ defined but not used

The last use of nsCaseConversionImp2Constructor was removed in bug 575043:
> -    { &kNS_UNICHARUTIL_CID, false, NULL, nsCaseConversionImp2Constructor },

Trivial fix, coming up.
Attached patch fixSplinter Review
Assignee: smontagu → dholbert
Status: NEW → ASSIGNED
Attachment #500869 - Flags: review?(smontagu)
Severity: normal → trivial
OS: Linux → All
Hardware: x86 → All
Attachment #500869 - Flags: review?(smontagu) → review+
Comment on attachment 500869 [details] [diff] [review]
fix

Requesting approval.  Just removing a now-unused function (defined via a macro), fixing a build warning.
Attachment #500869 - Flags: approval2.0?
I forgot bug 585420, which will obsolete this.
Depends on: 585420
Fixed by bug 585420, which I just landed for timeless.
Assignee: dholbert → smontagu
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee: smontagu → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: