585483 - address autocomplete fails for combinations of bracket "["

Status: ASSIGNED

(MailNews Core :: Address Book, defect)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #496970 +++
from bug 496970 comment 12: a variant of attachment 390655 [details] [diff] [review] is
needed to fix addressbook search of brackets and autocomplete with brackets.
------

does anyone see [ totally fails for address book search?
(it does not for me)

however, autocomplete needs investigation, and perhaps more than one bug. These autocomplete issues are not limited to apostrophe. it fails for ' ( and [ and perhaps other non-alpha characters - makes my head spin. 

'anything  - no subset of characters works
b'yz  - no subset of characters works

try playing with az'bx'[z) in a name
also, a leading [ autocomplete fails with ldap

Comment 1

[Thomas D. (:thomas8)]

Wayne, could you add steps to this bug?

Comment 2

[Thomas D. (:thomas8)]

Wayne, for local ABs, I think everything works after bug 749097 fixed it for "(" and ")".

Can you test again for LDAP, and if problems still occur, add proper STR?

Otherwise, perhaps this is wfm.

Comment 3

[Thomas D. (:thomas8)]

Bug 703493 covers the ' case but also needs retesting (wfm for local ABs, can't test for LDAP)

Comment 4

[:aceman]

I don't think 749097 helped here as it only encodes ( and ), which are special for the Ab query language. Other chars were untouched, they should either be handled by the encodeURIComponent, or they are still buggy. But I can't reproduce. In the AB window quick search [, ] and ' do work for me fine. Also in compose autocomplete.

supposedly we can use https://howto.adams.edu/index.php/Thunderbird_-_Add_LDAP_to_Address_Book to try LDAP but I haven't tried it yet.

Comment 5

[Wayne Mery (:wsmwk)]

( fails for ldap

I can't speak for [

Comment 6

[:aceman]

For some reason I can't see patch from attachment 390655 [details] [diff] [review] in current trunk. Maybe it never landed? As I had to implement ( and ) in bug 749097. [ and ' and " do work for me in Local AB in current trunk.

So it seems this only needs to be checked on LDAP.

Comment 7

[:aceman]

For some reason I can't see patch from attachment 390655 [details] [diff] [review] in current trunk. Maybe it never landed? As I had to implement ( and ) in bug 749097. [ and ' and " do work for me in Local AB in current trunk.

So it seems this only needs to be checked on LDAP.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to :aceman from comment #6)
> For some reason I can't see patch from attachment 390655 [details] [diff] [review]
> [review] in current trunk. Maybe it never landed? As I had to implement (
> and ) in bug 749097. [ and ' and " do work for me in Local AB in current
> trunk.
> 
> So it seems this only needs to be checked on LDAP.

If you are asking me if it never landed, better to ask someone else :(

Comment 9

[:aceman]

So can anybody summarize what is still NOT working here?

1. [ works for me on local AB
2. I noticed " (double quote) does NOT work for me on local AB. ( ) ' already work.
3. (, ) and similar do NOT work on search in LDAP AB
4. for autocomplete, the LDAP search only looks in 'cn', 'sn', 'mail' fields (so probably names and emai). The addressbook search looks in many more fields. (It seems there can be some "autoComplete.filterTemplate" pref set for the AB, but I don't know where)

I already have a fix for 3.

Does anybody have an LDAP directory that contains the special characters in the name fields? I do not have such sample so can't check the autocomplete part.

Comment 10

[Wayne Mery (:wsmwk)]

In LOCAL AB
az'bx'[z) works
'anything works
[works? works
"works? works
(a"b)  works
(,anything) does not work

I did not test ldap

Comment 11

[Wayne Mery (:wsmwk)]

TCW does this reprodue for you?

Comment 12

[Arthur K. (he/him)]

STR using 110.0b4:

1. I created a generic user called (,some ,user) in AB with an email address of [e-mail]
2. I plugged into the To: field a bracket ( and only a previous address that had an < or an > in the user name populated, not the one with (,
3. I tried to plug into the To: field a (, but it fails and populates instead a username that has an < and > in their AB entry due to the , / comma input
4. I plugged into the To: the word user and (,some ,user) <[e-mail]> was one of the autocomplete choices and allowed me to use (,some ,user) <[e-mail]> in the To: field

So it seems it works if you input the alpha characters of the AB entry but not a preceding , or (, which may be correct behavior if one only expects standard alpha characters and no ( or ,