585494 - Admin blacklisted username form doesn't accept UTF-8

Status: VERIFIED FIXED

Description

[Wil Clouser [:clouserw]]

If I enter:

pâté en croûte

I get:


  File "/home/clouserw/dev/zamboni/apps/users/admin.py", line 52, in add_view
    if BlacklistedNickname.blocked(n):

  File "/home/clouserw/dev/zamboni/apps/users/models.py", line 207, in blocked
    nick = nick.decode().lower().encode('utf-8')

UnicodeEncodeError: 'ascii' codec can't encode character u'\xe2' in position 1: ordinal not in range(128)

Comment 1

[Jeff Balogh (:jbalogh)]

I'm suspicious of anyone saying .decode and .encode.  jsocol once explained this to me, but I promptly forgot.

Comment 2

[James Socol [:jsocol, :james]]

From: http://docs.python.org/library/stdtypes.html#str.decode

"encoding defaults to the default string encoding."

Is 'nick' a byte string or a unicode string when you decode() it? If it's a byte string, you may want to specify the encoding for decode().

Comment 3

[Barry Chen]

With a little help from django.utils: http://github.com/chenba/zamboni/commit/b3e06b93006be9d6b198cf25ff0595dd5455a0ae

Comment 4

[Wil Clouser [:clouserw]]

Awesome, thanks.  http://github.com/jbalogh/zamboni/commit/b3e06b93006be9d6b198cf25ff0595dd5455a0ae

Comment 5

[Stephen Donner [:stephend] PTO/paternity - back for All Hands]

Verified FIXED on https://preview.addons.mozilla.org/z/en-US/admin/models/users/blacklistednickname/add/.