If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

test_bug500328.html fails adding a visit due to a contention in page addition

RESOLVED FIXED

Status

()

Toolkit
Places
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

7 years ago
I had to disable test_bug500328.html with http://hg.mozilla.org/mozilla-central/rev/83ae1826aa80 due to a problem with page addition.
Page is added through 2 different apis, and visit addition fails to add the page due to constraint issues (someone other added the page before visit addition could do it). We should probably use an insert or ignore but this requires not having temp tables. Also removing the possibilities of this to happen is important.

btw, we should fix this and re-enable the test asap.
(Assignee)

Comment 1

7 years ago
I had backed out the test disable code when I backed out temp tables patch. currently I have fixed switch to tab and getBookmarkedURIFor so that they won't try to add new pages. This should be enough btw if it's not should be fixed along with bug 552023.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(In reply to comment #1)
> I had backed out the test disable code when I backed out temp tables patch.
> currently I have fixed switch to tab and getBookmarkedURIFor so that they won't
> try to add new pages. This should be enough btw if it's not should be fixed
> along with bug 552023.
So, I'm still seeing this failure on the places branch when I land the changes in bug 552023.  Doesn't look like it's enough, so any ideas?
(Assignee)

Comment 3

7 years ago
This failure when it happened was due to bug 585966, do you see a 19 constraint failed?
(In reply to comment #3)
> This failure when it happened was due to bug 585966, do you see a 19 constraint
> failed?
I don't see that no.  Error log (http://tinderbox.mozilla.org/showlog.cgi?log=Places/1285182056.1285184831.32188.gz&fulltext=1#err0) indicates that the color never got updated.
(In reply to comment #3)
> This failure when it happened was due to bug 585966, do you see a 19 constraint
> failed?
the opt failure appears to be the same: http://tinderbox.mozilla.org/showlog.cgi?log=Places/1285188091.1285189244.19135.gz&fulltext=1#err0
You need to log in before you can comment on or make changes to this bug.