Closed Bug 585966 Opened 15 years ago Closed 15 years ago

Async-sync contentions when adding new pages ("19 constraint failed" error)

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b4
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

patch v1.0
1.33 KB, patch
sdwilsh
: review+
Details | Diff | Splinter Review
We get failures in various browser chrome and chrome tests with a reported "19 constraint failed" error. When this happens visits are not added. It could be due to page addition being done both sync and async (so async stmt for insertion is prepared, sync stmt executes, then async stmt fails insertion due to constraint). pushing Bug 584731 made this pretty visible
blocking2.0: --- → ?
Depends on: 546253, 585969
Blocks: 584731
Attached patch patch v1.0 — — Splinter Review
This covers cases where both sync and async addNewPage are acting, there is no need to fail. This fixes the code for cases we can't handle, I'll also act in other bugs to fix the callers we can change.
Attachment #464497 - Flags: review?(sdwilsh)
blocking2.0: ? → betaN+
Comment on attachment 464497 [details] [diff] [review] patch v1.0 This would be pretty darn difficult to test, but r=sdwilsh without the test.
Attachment #464497 - Flags: review?(sdwilsh) → review+
yeah, it's time sensitive, so testing is hard, but I've tested it through the permaorange caused by bug 584731
Whiteboard: [can land]
I pushed this some day ago. http://hg.mozilla.org/mozilla-central/rev/87aa7e6b7376
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Whiteboard: [can land]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: