585770 - Make Mozmill-test testPasswordNotSaved local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testPasswordManager/testPasswordNotSaved.js
Test-page: test-files/password_manager/login_form.html

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

Cleanup and simple swap to local-test data

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 466321 [details] [diff] [review]
Patch v1 - (default)

>-  controller.assertProperty(removeLogin, 'disabled', 'true');
>+  controller.assertDOMProperty(removeLogin, 'disabled', 'true');

Don't use assertDOMProperty yet. We haven't upgraded Mozmill to 1.5 on our boxes.

Comment 3

[Aaron Train [:aaronmt]]

Now that it has, is the same patch ok?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Use the old way. We will update all instances at once.

Comment 5

[Aaron Train [:aaronmt]]

Attachment: Patch v1.1 - (default)

revert back to assertProperty

Comment 6

[u279076]

Comment on attachment 471519 [details] [diff] [review]
Patch v1.1 - (default)

>+  pm = Cc["@mozilla.org/login-manager;1"]
>+          .getService(Ci.nsILoginManager);

Fix . and indentation

Comment 7

[Aaron Train [:aaronmt]]

Attachment: Patch v1.2 - [nit fix] - (default)

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 473514 [details] [diff] [review]
Patch v1.2 - [nit fix] - (default)

r=me.

Please file a follow-up bug to separate the two test functions into their own modules.

Comment 9

[u279076]

(In reply to comment #8)
> Please file a follow-up bug to separate the two test functions into their own
> modules.

Filed -> bug 599148

Comment 10

[u279076]

(In reply to comment #7)
> Created attachment 473514 [details] [diff] [review]
> Patch v1.2 - [nit fix] - (default)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/4f11520b6ac2 [default]
http://hg.mozilla.org/qa/mozmill-tests/rev/625a7b91b3cf [mozilla1.9.2]
http://hg.mozilla.org/qa/mozmill-tests/rev/1e98eca8ee8b [mozilla1.9.1]

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.