Closed
Bug 585873
Opened 14 years ago
Closed 14 years ago
implement RealBreak for arm
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: blassey, Assigned: blassey)
References
Details
Attachments
(1 file)
|
1001 bytes,
patch
|
dougt
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Implementing this allows us to break on assertions in the code making debugging easier. This patch also turns the "don't know how to break on this platform" comment into a #error, as I think it would be better to not silently fail here.
Attachment #464330 -
Flags: review?(doug.turner)
|
Assignee | |
Updated•14 years ago
|
Attachment #464330 -
Flags: approval2.0?
|
||
Comment 1•14 years ago
|
||
Comment on attachment 464330 [details] [diff] [review] patch looks right according to: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0068b/CIHBIGGI.html On what platform did you just create a build error for? GNUC + PPC? I'd be totally happy with #warning, but maybe start with #error and file followups to get those fixed.
Attachment #464330 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
> On what platform did you just create a build error for? GNUC + PPC?
It passed a try server run with no complaints. Is there a list of tier 2 platforms somewhere?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 464330 [details] [diff] [review] patch I'd prefer a #warning, not an error.
Attachment #464330 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0c63d1c53e49
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Assignee: nobody → blassey.bugs
You need to log in
before you can comment on or make changes to this bug.
Description
•