596070 - Fix nsDebugImpl.cpp build warnings for "missing terminating ' character"

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

While building mozilla-central, I get this compile-spew:
> xpcom/base/nsDebugImpl.cpp:405:13: warning: missing terminating ' character
> xpcom/base/nsDebugImpl.cpp:509:13: warning: missing terminating ' character

This is from these lines:
> 405 #warning don't know how to break on this platform
> 509 #warning don't know how to break on this platform
http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsDebugImpl.cpp#405

The preprocessor seems to be interpreting the apostrophe in "don't" as an unmatched single-quote.

If I wrap the whole warning message in double-quotes, that seems to fix the issue.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: add double-quotes

Comment 2

[Doug Turner (:dougt)]

Maybe it is safer to just change: don't to do not?

Comment 3

[Daniel Holbert [:dholbert]]

FWIW, we do have instances of |#warning "quoted message"| in our code already.  But agreed, it's probably less intrusive if I avoid introducing more quotes.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: fix: s/don't/do not/

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 474918 [details] [diff] [review]
fix: s/don't/do not/

requesting approval2.0 - trivial zero-risk change to fix two build warnings that were introduced last month.

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 474918 [details] [diff] [review]
fix: s/don't/do not/

low risk.

Comment 7

[Daniel Holbert [:dholbert]]

Landed:
http://hg.mozilla.org/mozilla-central/rev/ab3235d80545