586219 - Title bar is not updated when switching tabs

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Christophe Calvez]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre

When switching tabs, the title bar is not updated to change to the tab content's title. It is updated when switching windows.

Reproducible: Always

Steps to Reproduce:
1. Open 2 tabs with different content
2. switch tabs, either by clicking on tab or by keyboard shortcut CTRL+TAB
Actual Results:  
The window title is not updated to show the title of the tab's content.

Expected Results:  
The title bar should update on tab switch to show the page's title.

Worked in beta 1, doesn't in trunk build 20100810043009.
Happens in safe mode too (no add-on, no persona).

Comment 1

[Christophe Calvez]

Works fine in 4.0b3 build 20100805192522.
Works fine in 4.0b4pre build 20100809040505.

Comment 2

[Alice0775 White]

It happens on Windows 7 Classic style also.

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/f26255ffe0c9
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100809 Minefield/4.0b4pre ID:20100809191130
Fails:
http://hg.mozilla.org/mozilla-central/rev/a0d6e4d37273
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100809 Minefield/4.0b4pre ID:20100809193558
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f26255ffe0c9&tochange=a0d6e4d37273

Comment 3

[[e-mail]]

Attachment: Proposed patch

mNonClientMargins needs to be protected by mCustomNonClient.

This affects all Windows non-custom window non-client title bar updates.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Shouldn't this be "if (mCustomNonClient && mNonClientMargins.top == -1)"?

Comment 5

[[e-mail]]

No, we only want to execute this code for a custom non-default top margin. So the problem is that we want to bail out early in more cases, not fewer.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/a16044df7223

Comment 8

[pal-moz]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b4pre) Gecko/20100814 Minefield/4.0b4pre ID:20100816070744

happen again.
maybe caused by backout, https://bugzilla.mozilla.org/show_bug.cgi?id=575870#c72


reopen ??