586486 - thumbnail zoom expands to wrong position

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Justin Dolske [:Dolske]]

When zooming a thumbnail (by selecting it, to return to the normal tab view), the thumbnail seems to zoom to the size of the full browser window. But it seems like it _should_ be zooming to the normal tab content area, eg the top should be offset by the height of the browser's chrome UI.

example that makes it obvious:
1) start in normal view, note physical top edge of site content
2) switch to tabview
3) Position group/thumbnail so that the top edge of the thumbnail is at the point noted in step 1
4) select thumbnail to return to normal view

The top edge of the thumbnail should remain fixed as it zooms, instead it's growing up towards the top of the window, resulting in a jarring transition when the tabview flips back to normal mode.

Comment 1

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

good visual polish to get for final, especially on slower systems

Comment 3

[Ian Gilman [:iangilman]]

I disagree. The impression we're trying to give with the zoom is that you're zooming out of the entire window, including the nav bar. While we don't literally zoom the nav bar away (though this is being looked into in bug 597713), zooming the way we do gives that impression better than if we left a gap for the nav bar.

As for slower systems, we're looking into an alternate animation that will be different (such as perhaps a bounding box zoom without the thumbnail), i.e. bug 597458.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

If Ian says that the other two bugs will resolve the jankiness that Dolske's reporting, then I'm fine with that. The bit I want to avoid is:

> growing up towards the top of the window, resulting in a jarring transition
> when the tabview flips back to normal mode.

Reopen if those other bugs won't fix that.