Use real computed values instead of made up ones in GroupItem.getContentBounds

RESOLVED WONTFIX

Status

P4
normal
RESOLVED WONTFIX
8 years ago
3 years ago

People

(Reporter: mitcho, Unassigned)

Tracking

Trunk
Future

Firefox Tracking Flags

(Not tracked)

Details

Right now we use constants to compute the available "content bounds" of group items. Let's actually compute this based on the computed styles of the group item. 

groupitems.js:
>    box.inset(6, 6);
>    box.height -= 33; // For new tab button

Comment 1

8 years ago
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Component: TabCandy → TabCandy
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Version: unspecified → Trunk
QA Contact: tabcandy → tabcandy
Keywords: helpwanted
Whiteboard: [good first bug]
Priority: -- → P3

Comment 2

8 years ago
Adding to b9 for themeability.
Blocks: 598154
Priority: P3 → P4
Target Milestone: --- → Firefox 4.0
(In reply to comment #2)
> Adding to b9 for themeability.

I'm fine with this if it's easy and doesn't have unintended consequences (see bug 597931). Otherwise I recommend we attack theme-ability after ff4.0.

Comment 4

8 years ago
bugspam (moving b9 to b10)
Blocks: 608028

Comment 5

8 years ago
bugspam (removing b9)
No longer blocks: 598154

Comment 6

8 years ago
Punting
No longer blocks: 608028
Target Milestone: Firefox 4.0 → Future
mitcho, is this bug still relevant? Will it still make a good first bug? I notice that it hasn't been changed in a couple of years. Thanks!
Flags: needinfo?(mitcho)
(In reply to Liz Henry :lizzard from comment #7)
> mitcho, is this bug still relevant? Will it still make a good first bug? I
> notice that it hasn't been changed in a couple of years. Thanks!

Unfortunately Panorama (Tab Groups) is slated for removal from Firefox in the near future (bug #836758), so I don't think that this is a particularly relevant or worthwhile bug to pursue at this time. Furthermore, as no reviewers are actively engaged with Panorama, reviewing a patch to accept it may also take time. Sorry about that. :(
Flags: needinfo?(mitcho)
Whiteboard: [good first bug]
Keywords: helpwanted
Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.