groupItemStorageSanity: if it's a check, let's really check it!

RESOLVED FIXED in Firefox 8

Status

Firefox Graveyard
Panorama
P4
normal
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: mitcho, Assigned: raymondlee)

Tracking

Trunk
Firefox 8

Details

(Whiteboard: [qa-][testday-20110930])

Attachments

(1 attachment, 1 obsolete attachment)

In GroupItems.groupItemStorageSanity, we currently only check that the groupItemData has bounds. We should check for everything.
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Component: TabCandy → TabCandy
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Version: unspecified → Trunk

Updated

7 years ago
QA Contact: tabcandy → tabcandy
(Reporter)

Updated

7 years ago
Priority: -- → P4

Comment 2

7 years ago
This seems like something we can punt on? Mitcho, let me know if you disagree.
Target Milestone: --- → Future
(Reporter)

Comment 3

7 years ago
(In reply to comment #2)
> This seems like something we can punt on? Mitcho, let me know if you disagree.

Agreed.
(Assignee)

Comment 4

6 years ago
Created attachment 549149 [details] [diff] [review]
v1
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #549149 - Flags: review?(tim.taubert)
Comment on attachment 549149 [details] [diff] [review]
v1

Review of attachment 549149 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

r=me with the comments addressed.

::: browser/base/content/tabview/groupitems.js
@@ +2237,1 @@
>      if (!Utils.isRect(groupItemData.bounds)) {

Please add a check for .bounds here before we access it.

@@ +2238,5 @@
>        Utils.log('GroupItems.groupItemStorageSanity: bad bounds', groupItemData.bounds);
>        sane = false;
> +    } else if ((groupItemData.userSize &&
> +                !Utils.isPoint(groupItemData.userSize)) ||
> +              !groupItemData.id) {

Nit: please correct the indentation here.
Attachment #549149 - Flags: review?(tim.taubert) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 550947 [details] [diff] [review]
Patch for checkin

(In reply to Tim Taubert [:ttaubert] from comment #5)
> r=me with the comments addressed.
> 
> ::: browser/base/content/tabview/groupitems.js
> @@ +2237,1 @@
> >      if (!Utils.isRect(groupItemData.bounds)) {
> 
> Please add a check for .bounds here before we access it.
> 
Added

> @@ +2238,5 @@
> >        Utils.log('GroupItems.groupItemStorageSanity: bad bounds', groupItemData.bounds);
> >        sane = false;
> > +    } else if ((groupItemData.userSize &&
> > +                !Utils.isPoint(groupItemData.userSize)) ||
> > +              !groupItemData.id) {
> 
> Nit: please correct the indentation here.
Fixed

Passed Try http://tbpl.mozilla.org/?tree=Try&rev=ede4c63a8d9c
Attachment #549149 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/fx-team/rev/7715c3c492ae
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Target Milestone: Future → ---
http://hg.mozilla.org/mozilla-central/rev/7715c3c492ae
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8

Comment 9

6 years ago
What can QA do to verify this?
Whiteboard: [qa+]
(In reply to Matt Evans [:mevans] from comment #9)
> What can QA do to verify this?

This seems pretty code-specific to me; I don't think there is much QA can do to verify this fix. If a testcase or steps can be provided please reset to qa+.

Thanks.
Whiteboard: [qa+] → [qa-][testday-20110930]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.