586772 - produce android builds with --disable-thumb2

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

I'd like to start producing builds with thumb2 disabled in parallel to our current thumb2 enabled builds. This will help us evaluate how we run on older devices and make sure we don't regress there.

It'll also allow people to test nightlies in the android emulator since its ARMv7 support leaves something to be desired.

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Does this need to be run per-checkin or can it be run nightly?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

as discussed on irc, nightly only is fine.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbot-configs patch v1

This should be what is required.

This should upload things to latest-android-r7-nothumb.

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

I will run this in staging the next time I have a staging environment booked out, should be today or tomorrow I hope.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: just the mozconfigs

Just the mozconfigs

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

I got 

ExecutableAllocatorPosix.cpp
/tools/android-ndk/build/prebuilt/linux-x86/arm-eabi-4.4.0/bin/arm-eabi-g++ -o ExecutableAllocatorPosix.o -c  -fvisibility=hidden -DOSTYPE=\"eabi\" -DOSARCH=eabi -DEXPORT_JS_API -D__STDC_LIMIT_MACROS -DJS_HAS_CTYPES -DDLL_PREFIX=\"lib\" -DDLL_SUFFIX=\".so\" -Ictypes/libffi/include -I.  -I/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/js/src -I. -I./../../dist/include -I./../../dist/include/nsprpub  -I/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/objdir/dist/include/nspr   -I/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/js/src -I/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/js/src/assembler -I/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/js/src/yarr  -fPIC -I/tools/android-ndk/build/platforms/android-5/arch-arm/usr/include  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-invalid-offsetof -Wno-variadic-macros -pedantic -Wno-long-long -mandroid -std=gnu++0x -I/tools/android-ndk/build/platforms/android-5/arch-arm/usr/include -msoft-float -fno-short-enums -fno-exceptions -fno-strict-aliasing -pipe  -DNDEBUG -DTRIMMED -g -O3 -fstrict-aliasing  -DENABLE_ASSEMBLER=1 -DUSE_SYSTEM_MALLOC=1 -DENABLE_JIT=1  -I/tools/android-ndk/build/platforms/android-5/arch-arm/usr/include  -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/ExecutableAllocatorPosix.pp /builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/js/src/assembler/jit/ExecutableAllocatorPosix.cpp
In file included from /builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/js/src/assembler/jit/ExecutableAllocatorPosix.cpp:26:
/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/js/src/assembler/jit/ExecutableAllocator.h:310:6: error: #error "The cacheFlush support is missing on this platform."
make[4]: *** [ExecutableAllocatorPosix.o] Error 1
make[4]: Leaving directory `/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/objdir/js/src'
make[3]: *** [libs_tier_js] Error 2
make[3]: Leaving directory `/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/objdir'
make[2]: *** [tier_js] Error 2
make[2]: Leaving directory `/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/objdir'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/builds/slave/mozilla-central-mobile-browser-android-r7-nothumb-nightly/build/mozilla-central/objdir'
make: *** [build] Error 2


Is this known breakage or is it something else?

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbot-configs v2

This patch adds a new platform (android-r7-nothumb) that builds using --disable-thumb2.  This patch also fixes bug 587150

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

This configuration produced some green builds on staging during the weekend.

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 466343 [details] [diff] [review]
buildbot-configs v2

We probably don't need symbols here. r=me if you set uploadSymbols to False.

I'll update my patch to change the SYMBOL_SERVER_PATH here after you land; I should probably also limit symbols by branch as well.

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 465836 [details] [diff] [review]
just the mozconfigs

http://hg.mozilla.org/build/buildbot-configs/rev/be0393c55128

Comment 11

[Aki Sasaki (not active)]

Comment on attachment 466343 [details] [diff] [review]
buildbot-configs v2

jhford landed this:

http://hg.mozilla.org/build/buildbot-configs/rev/2402168c27fb
http://hg.mozilla.org/build/buildbot-configs/rev/08d7313b22bb