586848 - Windows installer packaging changes in bug 556644 will break seamonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix

Just a heads up - we're going to end up breaking anything that uses the toolkit windows installer code. I ported the changes for Firefox to Seamonkey and it seems to work. Optional packages are currently not supported - I will fix it in a follow up bug for m-c. (optional packages are always installed at the moment)

Comment 1

[Michael Wu [:mwu]]

Attachment: Fix, v2

Updated fix based on things I learned while fixing thunderbird.

Comment 3

[Robert Kaiser]

We'll need to get this in for a respin of a3, as installers there don't work right now - probably as expected, but without review requests, it won't get far.

Comment 4

[Robert Kaiser]

Comment on attachment 465579 [details] [diff] [review]
Fix, v2

Requesting reviews from both Rob and Frank, we'll take the one from the first of you who comes around to it.
Note, as said above, this blocks SM 2.1a3 and will need to make the respin we'll be doing.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 465579 [details] [diff] [review]
Fix, v2

I didn't test the patch but it looks good to me!

Keep in mind that if / when you turn on omnijar you will need to update your removed-files.in

Comment 6

[Robert Kaiser]

mwu, will you be landing this?

If so, please land on both default and COMM20b4_20100815_RELBRANCH branches on comm-central. Thanks!

Comment 7

[Michael Wu [:mwu]]

http://hg.mozilla.org/comm-central/rev/2ced908a7516 (branch)
http://hg.mozilla.org/comm-central/rev/e58c1b036d73 (default)

Note that there still needs to be a followup bug to fix optional package support. This fix also hasn't been checked for proper locale repack of optional packages.

Comment 8

[Philip Chee]

> This fix also hasn't been checked for proper locale repack of optional
> packages.

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1282038326.1282039756.18931.gz

make[5]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir/suite/feeds/src'
make[5]: Entering directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir/suite/locales'
make[5]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir/suite/locales'
make[4]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir/suite'
make[3]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir'
Makefile:460: *** missing `endif'.  Stop.
NEXT ERROR make[4]: *** [locales_export] Error 2
make[3]: *** [export_tier_app] Error 2
make[2]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir'
make[1]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir'
make[2]: *** [tier_app] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2
program finished with exit code 2
elapsedTime=1072.609000
=== Output ended ===
======== BuildStep ended ========

Comment 9

[Robert Kaiser]

Fixed with http://hg.mozilla.org/comm-central/rev/ca5266533bd4 and the according changeset on the relbranch. mwu was apparently confused by Firefox using l10n.mk where this is in side a var and us not using that and having that as normal commands.