Closed Bug 586848 Opened 10 years ago Closed 10 years ago

Windows installer packaging changes in bug 556644 will break seamonkey


(SeaMonkey :: Build Config, defect)

Windows 7
Not set


(blocking-seamonkey2.1 a3+)

Tracking Status
blocking-seamonkey2.1 --- a3+


(Reporter: mwu, Assigned: mwu)




(1 file, 1 obsolete file)

Attached patch Fix (obsolete) — Splinter Review
Just a heads up - we're going to end up breaking anything that uses the toolkit windows installer code. I ported the changes for Firefox to Seamonkey and it seems to work. Optional packages are currently not supported - I will fix it in a follow up bug for m-c. (optional packages are always installed at the moment)
Attached patch Fix, v2Splinter Review
Updated fix based on things I learned while fixing thunderbird.
Attachment #465504 - Attachment is obsolete: true
Duplicate of this bug: 586919
Assignee: nobody → mwu
Flags: in-testsuite-
Version: unspecified → Trunk
We'll need to get this in for a respin of a3, as installers there don't work right now - probably as expected, but without review requests, it won't get far.
blocking-seamonkey2.1: --- → a3+
Comment on attachment 465579 [details] [diff] [review]
Fix, v2

Requesting reviews from both Rob and Frank, we'll take the one from the first of you who comes around to it.
Note, as said above, this blocks SM 2.1a3 and will need to make the respin we'll be doing.
Attachment #465579 - Flags: review?(robert.bugzilla)
Attachment #465579 - Flags: review?(bugzilla)
Comment on attachment 465579 [details] [diff] [review]
Fix, v2

I didn't test the patch but it looks good to me!

Keep in mind that if / when you turn on omnijar you will need to update your
Attachment #465579 - Flags: review?(robert.bugzilla) → review+
mwu, will you be landing this?

If so, please land on both default and COMM20b4_20100815_RELBRANCH branches on comm-central. Thanks!
Attachment #465579 - Flags: review?(bugzilla) (branch) (default)

Note that there still needs to be a followup bug to fix optional package support. This fix also hasn't been checked for proper locale repack of optional packages.
Closed: 10 years ago
Resolution: --- → FIXED
> This fix also hasn't been checked for proper locale repack of optional
> packages.

make[5]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir/suite/feeds/src'
make[5]: Entering directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir/suite/locales'
make[5]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir/suite/locales'
make[4]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir/suite'
make[3]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir'
Makefile:460: *** missing `endif'.  Stop.
NEXT ERROR make[4]: *** [locales_export] Error 2
make[3]: *** [export_tier_app] Error 2
make[2]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir'
make[1]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-debug/build/objdir'
make[2]: *** [tier_app] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2
program finished with exit code 2
=== Output ended ===
======== BuildStep ended ========
Fixed with and the according changeset on the relbranch. mwu was apparently confused by Firefox using where this is in side a var and us not using that and having that as normal commands.
Blocks: 602907
You need to log in before you can comment on or make changes to this bug.