Last Comment Bug 602907 - Mac release repackaging breaks with release file names
: Mac release repackaging breaks with release file names
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Robert Kaiser
:
:
Mentors:
Depends on: 586848
Blocks: SM2.1b1
  Show dependency treegraph
 
Reported: 2010-10-08 10:16 PDT by Robert Kaiser
Modified: 2010-10-08 11:50 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
b1+


Attachments
Fix the quotes (785 bytes, patch)
2010-10-08 10:26 PDT, Robert Kaiser
neil: review+
Details | Diff | Splinter Review

Description Robert Kaiser 2010-10-08 10:16:43 PDT
Due to a subtle change in bug 586848, we now break in Mac release L10n repacks due to the spaces in the file names, as we now double-quote a target name and that doesn't work out well.

See this error message from the 2.1b1 runs:

mv -f "../../mozilla/dist/l10n-stage/mac/ru/SeaMonkey 2.1 Beta 1.dmg" ""/builds/slave/macosx_repack/build/comm-central/suite/locales/../../mozilla/dist/mac/ru/SeaMonkey 2.1 Beta 1.dmg""
usage: mv [-f | -i | -n] [-v] source target
       mv [-f | -i | -n] [-v] source ... directory
make[1]: *** [repackage-zip] Error 64


The problem comes down to the ZIP_OUT var after http://hg.mozilla.org/comm-central/diff/e58c1b036d73/suite/locales/Makefile.in being different in quoting to the ZIP_OUT var after http://hg.mozilla.org/mozilla-central/diff/7cf1fba2029a/toolkit/locales/l10n.mk and due to us using that value in another set of quotes in the mv command, we fail. Linux (tar.bz2) and Windows (.zip) don't have spaces in their file names, so they dodge this, and apparently the different setting of the Windows .exe ZIP_OUT doesn't pose a problem as well, so actually, it turns out to fail on Mac only. Removing the quotes on ZIP_OUT should do it.
Comment 1 Robert Kaiser 2010-10-08 10:26:09 PDT
Created attachment 481873 [details] [diff] [review]
Fix the quotes

Here's what should fix this, I'll take reviews from the first of you who comes around to it, as we really should see to getting working Beta 1 builds going.
Comment 2 Robert Kaiser 2010-10-08 11:50:12 PDT
Thanks, landed as http://hg.mozilla.org/comm-central/rev/6151d5420a4c on relbranch and http://hg.mozilla.org/comm-central/rev/3b77515b996d on default.

Note You need to log in before you can comment on or make changes to this bug.