Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Mac release repackaging breaks with release file names

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

Trunk
seamonkey2.1b1
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(blocking-seamonkey2.1 b1+)

Details

Attachments

(1 attachment)

785 bytes, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Due to a subtle change in bug 586848, we now break in Mac release L10n repacks due to the spaces in the file names, as we now double-quote a target name and that doesn't work out well.

See this error message from the 2.1b1 runs:

mv -f "../../mozilla/dist/l10n-stage/mac/ru/SeaMonkey 2.1 Beta 1.dmg" ""/builds/slave/macosx_repack/build/comm-central/suite/locales/../../mozilla/dist/mac/ru/SeaMonkey 2.1 Beta 1.dmg""
usage: mv [-f | -i | -n] [-v] source target
       mv [-f | -i | -n] [-v] source ... directory
make[1]: *** [repackage-zip] Error 64


The problem comes down to the ZIP_OUT var after http://hg.mozilla.org/comm-central/diff/e58c1b036d73/suite/locales/Makefile.in being different in quoting to the ZIP_OUT var after http://hg.mozilla.org/mozilla-central/diff/7cf1fba2029a/toolkit/locales/l10n.mk and due to us using that value in another set of quotes in the mv command, we fail. Linux (tar.bz2) and Windows (.zip) don't have spaces in their file names, so they dodge this, and apparently the different setting of the Windows .exe ZIP_OUT doesn't pose a problem as well, so actually, it turns out to fail on Mac only. Removing the quotes on ZIP_OUT should do it.
(Assignee)

Updated

7 years ago
blocking-seamonkey2.1: --- → b1+
(Assignee)

Comment 1

7 years ago
Created attachment 481873 [details] [diff] [review]
Fix the quotes

Here's what should fix this, I'll take reviews from the first of you who comes around to it, as we really should see to getting working Beta 1 builds going.
Attachment #481873 - Flags: review?(neil)
Attachment #481873 - Flags: review?(bugspam.Callek)

Updated

7 years ago
Attachment #481873 - Flags: review?(neil) → review+
(Assignee)

Updated

7 years ago
Attachment #481873 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 2

7 years ago
Thanks, landed as http://hg.mozilla.org/comm-central/rev/6151d5420a4c on relbranch and http://hg.mozilla.org/comm-central/rev/3b77515b996d on default.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.