Fix display issues of tabs in the expando tray

RESOLVED WORKSFORME

Status

P3
normal
RESOLVED WORKSFORME
8 years ago
3 years ago

People

(Reporter: ashughes, Unassigned)

Tracking

Trunk
Future

Details

(Whiteboard: [visual][polish][good first bug])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 465740 [details]
Screenshot

If you shrink a tab group small enough, they are stacked together.  This enables an expand-view button (circle with 4 arrows coming out of it).  Looking at this expand-view displays tabs with rounded corners.  Flash content ignores this effect (see screenshot).

I suggest removing the rounded corners altogether to keep it fluid with the regular tab group view.

Comment 1

8 years ago
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Component: TabCandy → TabCandy
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Version: unspecified → Trunk

Updated

8 years ago
QA Contact: tabcandy → tabcandy
Assigning to Aza for design feedback.
Assignee: nobody → aza
Keywords: uiwanted
Priority: -- → P4

Comment 3

8 years ago
It is not just Flash, right now the tabs escape the rounded corners no matter what. We need to do a better job of displaying them.

Assigning to shorlander for the visual treatment.
Assignee: aza → shorlander
Status: NEW → ASSIGNED
blocking2.0: --- → ?
Summary: Rounded corners for expand-view ignores flash content → Fix display issues of tabs in the expando tray
Whiteboard: [visual]
Target Milestone: --- → Firefox 4.0
Sean might also have ideas. Aza, do you think this is a blocker?
I honestly can't tell what's going on in that screenshot, and this doesn't feel like a blocker based on the description.

Please feel free to renominate if you have a better illustration of why this is a don't ship Firefox 4 without it issue.
blocking2.0: ? → -

Comment 6

8 years ago
Definitely not a blocker. There is a small block border in the lower-right-hand corner. This fits into the visual polish of b9. It doesn't need design work, just cleanup.
Assignee: shorlander → nobody
Blocks: 598154
Priority: P4 → P3
Status: ASSIGNED → NEW

Comment 7

8 years ago
bugspam (moving b9 to b10)
Blocks: 608028

Comment 8

8 years ago
bugspam (removing b9)
No longer blocks: 598154

Comment 9

8 years ago
Punt
No longer blocks: 608028
Target Milestone: Firefox 4.0 → Future
Keywords: uiwanted
Whiteboard: [visual] → [visual][polish][good first bug]
It looks fine to me in the latest build.  Does it look ok to you?
(Reporter)

Comment 11

8 years ago
Yeah, seems fine to me.  I can no longer reproduce this bug.  Marking WORKSFORME.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WORKSFORME
(Assignee)

Updated

3 years ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.