Closed Bug 587102 Opened 10 years ago Closed 10 years ago

Expose whether direct2d is enabled to about:support

Categories

(Firefox :: General, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Attachment #465757 - Flags: review?(johnath)
OS: Mac OS X → All
I assume we can't just get this from looking at modified prefs (already included in about:support)?
(In reply to comment #1)
> I assume we can't just get this from looking at modified prefs (already
> included in about:support)?

Correct. The prefs say whether direct2d is explicitly desired. This says whether it's actually being used.
Comment on attachment 465757 [details] [diff] [review]
Add a graphics section to about:support that included whether d2d is enabled

CC/CI -> Cc/Ci, and don't double declare var d2d. If you fix those, run it, and it actually works, r=me on the obvious, fixed version.

Direct2D is not a string that needs to be localized, so I'm okay for it to be in there bare, but I wonder if it might be helpful to turn it into an actual sentence, given the distinction between "direct2d prefs are on, aspirationally" and "direct2d is actually functioning"? E.g.

"Direct2D Enabled" or "Direct2D Active"

Your call, really.
Attachment #465757 - Flags: review?(johnath) → review-
Attached patch v2 (obsolete) — Splinter Review
Attachment #465757 - Attachment is obsolete: true
Attachment #465830 - Flags: review?(johnath)
Wrong patch
Attached patch v3Splinter Review
Attachment #465830 - Attachment is obsolete: true
Attachment #465830 - Flags: review?(johnath)
Attachment #465832 - Flags: review?(johnath)
http://hg.mozilla.org/mozilla-central/rev/032abd339649
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Duplicate of this bug: 584179
Attachment #465832 - Flags: review?(johnath)
Depends on: 592406
No longer depends on: 592406
Assignee: nobody → jmuizelaar
You need to log in before you can comment on or make changes to this bug.