Closed Bug 587322 Opened 11 years ago Closed 11 years ago
Compilation broken on MOZ
_WINSDK _TARGETVER < MOZ _NTDDI _LONGHORN
GetDwmDLL is not guarded by MOZ_WINSDK_TARGETVER check and it accesses sDwmDLL, which is guarded,
This patch includes also a fix for nsWinWidgetFactory.cpp, where GfxInfoConstructor, that is in mozilla::widget namespace, is always accessed, but |using namespace mozilla::widget;| is protected by MOZ_WINSDK_TARGETVER guard.
Attachment #465994 - Flags: review?(tellrob) → review+
Does the NS_GENERIC_FACTORY_CONSTRUCTOR(GfxInfo) still need the namespaces?
Comment on attachment 465994 [details] [diff] [review] fix v1.1 a2.0=dbaron
Attachment #465994 - Flags: approval2.0? → approval2.0+
I applied the patch and it worked for me
Would be real nice to get this checked in.
http://hg.mozilla.org/mozilla-central/rev/4e5b0b3d1ea0 In the future, please follow these suggestions for using checkin-needed: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed It's a pain to have to manually set the user and checkin comment when landing your patch.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.