Closed Bug 587322 Opened 11 years ago Closed 11 years ago

Compilation broken on MOZ_WINSDK_TARGETVER < MOZ_NTDDI_LONGHORN

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix v1.0 (obsolete) — Splinter Review
GetDwmDLL is not guarded by MOZ_WINSDK_TARGETVER check and it accesses sDwmDLL, which is guarded,
Assignee: nobody → jacek
Attachment #465993 - Attachment is patch: true
Attachment #465993 - Flags: review?(tellrob)
Attached patch fix v1.1Splinter Review
This patch includes also a fix for nsWinWidgetFactory.cpp, where GfxInfoConstructor, that is in mozilla::widget namespace, is always accessed, but |using namespace mozilla::widget;| is protected by MOZ_WINSDK_TARGETVER guard.
Attachment #465993 - Attachment is obsolete: true
Attachment #465994 - Flags: review?(tellrob)
Attachment #465993 - Flags: review?(tellrob)
Attachment #465994 - Flags: review?(tellrob) → review+
Attachment #465994 - Flags: approval2.0?
Blocks: 583857
Does the NS_GENERIC_FACTORY_CONSTRUCTOR(GfxInfo) still need the namespaces?
Comment on attachment 465994 [details] [diff] [review]
fix v1.1

a2.0=dbaron
Attachment #465994 - Flags: approval2.0? → approval2.0+
I applied the patch and it worked for me
Would be real nice to get this checked in.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/4e5b0b3d1ea0

In the future, please follow these suggestions for using checkin-needed:
http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

It's a pain to have to manually set the user and checkin comment when landing your patch.
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.