Support disabling reftests on D2D

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

(Depends on: 2 bugs, Blocks: 1 bug)

Trunk
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

8 years ago
Blocks: 578110
(Assignee)

Comment 1

8 years ago
Created attachment 462502 [details] [diff] [review]
First cut at an implementation of the gfxinfo service
(Assignee)

Comment 2

8 years ago
Comment on attachment 462502 [details] [diff] [review]
First cut at an implementation of the gfxinfo service

This adds GfxInfo service that will let us get information like whether d2d is enabled. Right now there's a single implementation that lives in widget/windows.

Whether or not d2d is enabled is exposed as a global boolean. e.g.
random-if(d2d) == boxshadow-rounded-spread.html boxshadow-rounded-spread-ref.html
Attachment #462502 - Flags: feedback?(vladimir)
Attachment #462502 - Flags: feedback?(dbaron)
(Assignee)

Updated

8 years ago
Blocks: 549353
Comment on attachment 462502 [details] [diff] [review]
First cut at an implementation of the gfxinfo service

I'd be happy to call this r=dbaron if you want (though a gfx peer should probably also look at it).
Attachment #462502 - Flags: feedback?(dbaron) → feedback+
OS: Mac OS X → Windows 7
(Assignee)

Updated

8 years ago
Attachment #462502 - Flags: review?(roc)
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/d3293a155e32
http://hg.mozilla.org/mozilla-central/rev/3fdcf0ef7e82
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 5

8 years ago
Comment on attachment 462502 [details] [diff] [review]
First cut at an implementation of the gfxinfo service

>+namespace mozilla {
>+namespace widget {
>+NS_GENERIC_FACTORY_CONSTRUCTOR(GfxInfo)
>+}
>+}
...
>+  { &kNS_GFXINFO_CID, false, NULL, GfxInfoConstructor },
My build doesn't like this, but it likes mozilla::widget::GfxInfoConstructor
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> >+  { &kNS_GFXINFO_CID, false, NULL, GfxInfoConstructor },
> My build doesn't like this, but it likes mozilla::widget::GfxInfoConstructor

See bug 587322

Updated

8 years ago
Depends on: 587322
Depends on: 590010
(Assignee)

Updated

8 years ago
Attachment #462502 - Flags: feedback?(vladimir)
Depends on: 629617
Depends on: 629957
You need to log in before you can comment on or make changes to this bug.