Closed Bug 587541 Opened 12 years ago Closed 12 years ago

Stop trying to package FormNotifier.js, since it doesn't exist

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla4.0b5

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Attached patch rmSplinter Review
Well, strictly speaking I think it still exists in Weave-as-an-extension, but it doesn't exist in dist/bin/components since bug 487558 landed.
Attachment #466195 - Flags: review?(me)
Comment on attachment 466195 [details] [diff] [review]
rm

I should hurry up and make packager warnings fatal.
Attachment #466195 - Flags: review?(me) → review+
Problem is, the ones you can easily make fatal are the uninteresting ones - I can't remember the last time someone accidentally made a file disappear, but I can easily remember the last time someone forgot to package something that did exist. This mostly matters because Nick's going to see it while checking packaging for the next beta, and will have to make sure it was okay that it didn't exist.
I dunno what we can do about the general problem, except educate developers that they should be calling 'make package', or testing their builds from try, rather than using dist/bin.
Persuade them to also build --disable-tests, so the output of make package-compare is close to usable; teach package-compare about the things it shouldn't mind seeing, and make everything else fatal; move everything we don't want to ship out of dist/bin and package everything. Nothing short-range I know of, other than me building more often on more platforms, since my build scripts do finish with make package-compare.
Attachment #466195 - Flags: approval2.0?
(In reply to comment #4)
> move everything we don't
> want to ship out of dist/bin and package everything.

Yes, please.
Attachment #466195 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/3fadf3ab7652
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 4.0b5 → mozilla4.0b5
You need to log in before you can comment on or make changes to this bug.