587876 - Undetermined progress bars should use mozRequestAnimationFrame

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Currently undetermined progress bars use a timeout per instance. They should use mozRequestAnimationFrame.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 466495 [details] [diff] [review]
Patch, v1

Lovely!

Comment 3

[Dão Gottwald [:dao]]

Need approval before this can land.
The one approving it could kindly take care of bug 586621 as well...

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 466495 [details] [diff] [review]
Patch, v1

Requesting approval, this cuts down on a timer per progressmeter (which causes us to wake up much more than we need to). Really low risk.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/eef61fc41851

Comment 6

[[e-mail]]

Comment on attachment 466495 [details] [diff] [review]
Patch, v1

>+              // Width of chunk is 1/5 (determined by the ratio 2000:400) of the
>+              // total width of the progress bar. The left edge of the chunk
>+              // starts at -1 and moves all the way to 4. It covers the distance
>+              // in 2 seconds.
Out of interest, where did you get those figures from? The old undetermined progressmeter was deliberately designed to take longer for wider progressmeters, so that the progress bar didn't move too quickly. I can't remember quite what the formula was but it's something like (width + 600) / 750 seconds. So for instance for a progressmeter of width 150 pixels it would take 1 second.