588191 - Replace term "Personal Toolbar" by "Bookmarks Toolbar" in Help

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

The exact same bookmark folder is both called "Bookmarks Toolbar" (Bookmarks Manager, Sidebar) and "Personal Toolbar" (Bookmarks menu, Bookmarks toolbar button menu). This is confusing; at least one of them should be renamed so that they match. Help needs to be adapted then, too.

I'd go for "Bookmarks Toolbar".

Fun fact: Choose Properties on the "Personal Toolbar" folder. It shows "Bookmarks Menu" (same for Unsorted Bookmarks).

Comment 1

[Robert Kaiser]

True, we currently have some fun mashup of "Personal Toolbar" values copied from old suite versions and "Bookmarks Toolbar" copied from Firefox.

I think that the FF choice of "Bookmarks Toolbar" is quite logical, and probably more logical than just "Personal Toolbar" as it's really just bookmarks, but maybe we should at least for now go with a compromise and call it "Personal Bookmarks" or "Personal Bookmarks Toolbar", depending on the available widths for string lengths.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Since this bug is not about renaming the Personal Toolbar itself but the special bookmarks folder, "Personal Toolbar Bookmarks" might be best (cf. "Unsorted Bookmarks"). I think "Personal Bookmarks" misses the relation to the Personal Toolbar, it sounds like "my bookmarks" (and all bookmarks are mine, right?).

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Since the main work will be done in bug 588807 now, I'm transforming this into the bug for the Help update.

Comment 4

[Devika Sugathan]

Hello, I'm an absolute beginner and would like to work on this.

Comment 5

[Nuno Silva [:njsg]]

Attachment: 588191-help-rename-bookmarks-toolbar

First version of a patch to rename the personal toolbar in help. I've also tried to update the surrounding text on bookmarks. (This should address bug 1288184 as well.)

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9192193 [details] [diff] [review]
588191-help-rename-bookmarks-toolbar

Missing </li> in suite/locales/en-US/chrome/common/help/customize_help.xhtml

• <li>Properties for the currently selected bookmark will appear in the bottom
• part of the window.

suite/locales/en-US/chrome/common/help/help-index1.rdf:

•     nc:name="personal toolbar"
  

•     nc:name="bookmarks toolbar"
  

If you search for bookmarks toolbar this is the only location in small caps. Would change it to Bookmarks Toolbar.

f+ for the moment.

Comment 7

[Nuno Silva [:njsg]]

Attachment: 588191-help-rename-bookmarks-toolbar

A new version, with one more closing tag than the previous one (also capitalizes the help-index1.rdf entry).

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9192906 [details] [diff] [review]
588191-help-rename-bookmarks-toolbar

"you can select <q>Bookmark this group of tabs</q>"

Capitalization was and is wrong here.

• accessed using the Sidebar Bookmarks tab, the Library window, and"

Shouldn't this be "...window or" ?

Otherwise fine for me and r/a+ implied. IanN should take a final look for grammar errors.

Comment 9

[Ian Neal]

Comment on attachment 9192906 [details] [diff] [review]
588191-help-rename-bookmarks-toolbar

Other than what frg spotted there is also:

>+++ b/suite/locales/en-US/chrome/common/help/customize_help.xhtml
> <ol>
>   <li>Open the Bookmarks menu and choose Manage Bookmarks.</li>
>+  <li>Select the <q>Bookmarks Toolbar</q> folder.</li>
>+  <li>Choose New Folder from the File menu.</li>
>+  <li> Type a name for your new bookmark folder. By default, the name is
Nit: remove the space before Type

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 588191-help-rename-bookmarks-toolbar-2536.patch

Fixed version. r/a+ from me.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ab0d70a107ce
Update bookmarks help. r=frg

Comment 12

[Ian Neal]

Comment on attachment 9193132 [details] [diff] [review]
588191-help-rename-bookmarks-toolbar-2536.patch

Sorry, only just noticed this whilst doing localisations. For a follow-up patch:

>+++ b/suite/locales/en-US/chrome/common/help/customize_help.xhtml

>-    <li><a href="#personal_toolbar">Personal Toolbar</a></li>
>+    <li><a href="#personal_toolbar">Bookmarks Toolbar</a></li>
Also change href, so #bookmarks_toolbar

>-<h3 id="personal_toolbar">Personal Toolbar</h3>
>+<h3 id="personal_toolbar">Bookmarks Toolbar</h3>
Also change id, so "bookmarks_toolbar"

>-    <td><img src="images/personalbar.png" alt="Personal Toolbar"/></td>
>+    <td><img src="images/personalbar.png" alt="Bookmarks Toolbar"/></td>
Is image still correct? If so will need to be renamed to bookmarksbar.png and link changed.

>-<h4 id="adding_personal_toolbar_bookmarks">Adding Personal Toolbar
>+<h4 id="adding_personal_toolbar_bookmarks">Adding Bookmarks Toolbar
Also change id and any links to it.

>     <a href="#adding_bookmark_folders_to_the_personal_toolbar">Adding Bookmark
Also change href.
>-    Folders to the Personal Toolbar</a>.</li>
>+    Folders to the Bookmarks Toolbar</a>.</li>

> <p id="adding_bookmark_folders_to_the_personal_toolbar"><strong>Adding
Also change id and links to it.

>-        <p>For more information about adding bookmarks to the Personal Toolbar,
>-          see <a href="#adding_personal_toolbar_bookmarks">Adding Personal
>+        <p>For more information about adding bookmarks to the Bookmarks Toolbar,
>+          see <a href="#adding_personal_toolbar_bookmarks">Adding Bookmarks
Also change this href.

>-    <td><img src="images/personalbar.png" alt="Personal Toolbar"/></td>
>+    <td><img src="images/personalbar.png" alt="Bookmarks Toolbar"/></td>
See earlier comment.

>+++ b/suite/locales/en-US/chrome/common/help/glossary.xhtml

>-  bookmark icon in the <a href="#personal_toolbar">Personal Toolbar</a> or
>+  bookmark icon in the <a href="#personal_toolbar">Bookmarks Toolbar</a> or
Also change this href.

>-<dt id="personal_toolbar">Personal Toolbar</dt><dd>The customizable toolbar
>+<dt id="personal_toolbar">Bookmarks Toolbar</dt><dd>The customizable toolbar
Also change this id and hrefs to it.

>+++ b/suite/locales/en-US/chrome/common/help/help-glossary.rdf
>-        <rdf:li> <rdf:Description nc:name="Personal Toolbar" nc:link="glossary.xhtml#personal_toolbar"/> </rdf:li>
>+        <rdf:li> <rdf:Description nc:name="Bookmarks Toolbar" nc:link="glossary.xhtml#personal_toolbar"/> </rdf:li>
Should be moved to the B section as it is alphabetically ordered, plus the link needs to be changed.

>+++ b/suite/locales/en-US/chrome/common/help/help-index1.rdf

>        <rdf:Description ID="toolbar:personal_toolbar"
>-         nc:name="personal toolbar"
>+         nc:name="Bookmarks Toolbar"
>          nc:link="customize_help.xhtml#personal_toolbar"/>
Also ID and link need changing.

>+++ b/suite/locales/en-US/chrome/common/help/suite-toc.rdf
>-        <rdf:li> <rdf:Description ID="cust-personal" nc:name="Personal Toolbar"  nc:link="customize_help.xhtml#personal_toolbar"/> </rdf:li>
>+        <rdf:li> <rdf:Description ID="cust-personal" nc:name="Bookmarks Toolbar"  nc:link="customize_help.xhtml#personal_toolbar"/> </rdf:li>
Also ID and link need changing.

Comment 13

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/d334f39cfe31920a53e15ad6356d0be9ccf949f2
Update bookmarks help. r=frg a=frg