Closed Bug 588342 Opened 9 years ago Closed 9 years ago

console should restore focus to proper place when closed

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dietrich, Assigned: msucan)

References

Details

(Whiteboard: [kd4b7] [patchclean:0917])

Attachments

(1 file, 1 obsolete file)

ideally would restore focus to where it was when the console was opened.

but i'd settle for just focusing the content document.
Agreed that the focus should land somewhere useful when the console is closed. I'm not sure about restoring it to where it was when the console was opened, though, because the user can move around on the page even while the console is opened.

Returning focus to the document is definitely a win though over doing nothing.
Whiteboard: [kd4b6]
Assignee: nobody → pwalton
Severity: normal → blocker
Reprioritizing bugs. You can filter the mail on the word TEABAGS.
Severity: blocker → normal
Whiteboard: [kd4b6] → [kd4b7]
Blocks: devtools4b8
Assignee: pwalton → mihai.sucan
Attached patch proposed fix and test code (obsolete) — Splinter Review
Proposed fix and test code.
Attachment #474573 - Flags: feedback?(ddahl)
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
Whiteboard: [kd4b7] → [kd4b7] [patchclean:0912]
Attachment #474573 - Flags: feedback?(ddahl) → feedback+
Comment on attachment 474573 [details] [diff] [review]
proposed fix and test code

Thanks David for the feedback+! Asking for review from Dietrich.
Attachment #474573 - Flags: review?(dietrich)
Attachment #474573 - Flags: review?(dietrich) → review+
Comment on attachment 474573 [details] [diff] [review]
proposed fix and test code

Thanks Dietrich for the review+! Asking for approval2.0+ for Firefox 4. This is a patch for polishing the UI of the new Web Console.
Attachment #474573 - Flags: approval2.0?
Attachment #474573 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
Rebased patch for mozilla-central.
Attachment #474573 - Attachment is obsolete: true
Whiteboard: [kd4b7] [patchclean:0912] → [kd4b7] [patchclean:0917]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 476271 [details] [diff] [review]
[checked-in] rebased patch

http://hg.mozilla.org/mozilla-central/rev/3c500e3e7dd3
Attachment #476271 - Attachment description: rebased patch → [checked-in] rebased patch
Depends on: 604960
Depends on: 1241707
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.