588342 - console should restore focus to proper place when closed

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

ideally would restore focus to where it was when the console was opened.

but i'd settle for just focusing the content document.

Comment 1

[Kevin Dangoor]

Agreed that the focus should land somewhere useful when the console is closed. I'm not sure about restoring it to where it was when the console was opened, though, because the user can move around on the page even while the console is opened.

Returning focus to the document is definitely a win though over doing nothing.

Comment 2

[Kevin Dangoor]

Reprioritizing bugs. You can filter the mail on the word TEABAGS.

Comment 3

[Mihai Sucan [:msucan]]

Attachment: proposed fix and test code

Proposed fix and test code.

Comment 4

[Mihai Sucan [:msucan]]

Comment on attachment 474573 [details] [diff] [review]
proposed fix and test code

Thanks David for the feedback+! Asking for review from Dietrich.

Comment 5

[Mihai Sucan [:msucan]]

Comment on attachment 474573 [details] [diff] [review]
proposed fix and test code

Thanks Dietrich for the review+! Asking for approval2.0+ for Firefox 4. This is a patch for polishing the UI of the new Web Console.

Comment 6

[Mihai Sucan [:msucan]]

Attachment: [checked-in] rebased patch

Rebased patch for mozilla-central.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 476271 [details] [diff] [review]
[checked-in] rebased patch

http://hg.mozilla.org/mozilla-central/rev/3c500e3e7dd3