588394 - The tabview image file are way too big

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alfred Kayser]

Attachment: Screendump of pnggauntlet as proof

Images used for tabcandy: edit.png, edit-light.png, and stack-expander are very big: 48 kilobytes each. Applying PNGGauntlet on them savings 140 KB, reducing each to less than 1KB.

(What is hidden in that 47KB?)

Comment 1

[Alfred Kayser]

Note, this impacts the total size of the Firefox distribution, as those 140KB are not compressible.

Comment 2

[Dão Gottwald [:dao]]

If you attach a patch with the fixed images, I can review it.

Comment 3

[Ed Lee :Mardak]

Sean, did you create these images? Might be interesting to know if there's something common in the creation process that results in these large files. Could be useful in other places to reduce file sizes initially.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Alfred, as Dāo suggested, if you could provide the patch (or even just your version of the images) that would be great!

Comment 5

[Alfred Kayser]

Attachment: Zip with optimized images

This is just a matter of replacing the images in the tabview directories, with those from the zipfile:
/browser/themes/winstripe/browser/tabview/
/browser/themes/pinstripe/browser/tabview/
/browser/themes/gnomestripe/browser/tabview/

Comment 6

[Alfred Kayser]

Ps. the edit-light is just a lighter version of edit (as the name implies), so an opacity on the edit image would also do.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Dao: ready for your review! :)

Comment 8

[Aza Raskin [:aza]]

(In reply to comment #3)
> Sean, did you create these images? Might be interesting to know if there's
> something common in the creation process that results in these large files.
> Could be useful in other places to reduce file sizes initially.

I created the images and left them in native Fireworks format (which also happens to be PNG). So they still have layer data and all that. Forgot to compress them later on.

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e9e0fe038a5a

Comment 10

[Alfred Kayser]

Size of firefox-4.0b6pre.en-US.win32.zip:
Before:13916802 
After: 13712343

So, this removes 200 KiB from the distribution package.

Thanks for fixing this.

Comment 11

[Aza Raskin [:aza]]

Thank you!