Closed Bug 588394 Opened 9 years ago Closed 9 years ago

The tabview image file are way too big

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 4.0b7
Tracking Status
blocking2.0 --- final+

People

(Reporter: alfredkayser, Assigned: alfredkayser)

Details

Attachments

(2 files)

Images used for tabcandy: edit.png, edit-light.png, and stack-expander are very big: 48 kilobytes each. Applying PNGGauntlet on them savings 140 KB, reducing each to less than 1KB.

(What is hidden in that 47KB?)
Note, this impacts the total size of the Firefox distribution, as those 140KB are not compressible.
OS: Windows XP → All
Hardware: x86 → All
Version: unspecified → Trunk
Blocks: 586788
If you attach a patch with the fixed images, I can review it.
Component: TabCandy → Theme
QA Contact: tabcandy → theme
Sean, did you create these images? Might be interesting to know if there's something common in the creation process that results in these large files. Could be useful in other places to reduce file sizes initially.
blocking2.0: --- → ?
No longer blocks: 586788
Alfred, as Dāo suggested, if you could provide the patch (or even just your version of the images) that would be great!
This is just a matter of replacing the images in the tabview directories, with those from the zipfile:
/browser/themes/winstripe/browser/tabview/
/browser/themes/pinstripe/browser/tabview/
/browser/themes/gnomestripe/browser/tabview/
Ps. the edit-light is just a lighter version of edit (as the name implies), so an opacity on the edit image would also do.
Dao: ready for your review! :)
Assignee: nobody → alfredkayser
blocking2.0: ? → final+
(In reply to comment #3)
> Sean, did you create these images? Might be interesting to know if there's
> something common in the creation process that results in these large files.
> Could be useful in other places to reduce file sizes initially.

I created the images and left them in native Fireworks format (which also happens to be PNG). So they still have layer data and all that. Forgot to compress them later on.
Attachment #470289 - Flags: review?(dao)
Attachment #470289 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/e9e0fe038a5a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Size of firefox-4.0b6pre.en-US.win32.zip:
Before:13916802 
After: 13712343

So, this removes 200 KiB from the distribution package.

Thanks for fixing this.
Status: RESOLVED → VERIFIED
Thank you!
You need to log in before you can comment on or make changes to this bug.