588895 - Implement getBrowser() in MailNews windows

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Robert Kaiser]

Thunderbird has a getBrowser() implementation in its mail window, originally introduced for their use of the find bar, but also used with toolkit's zoom manager and potentially others, see http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindow.js#506

We should implement it for the same reasons as well as for Thunderbird add-on compat.

I'll need it for the zoom manager in bug 386363, for one thing.

Comment 1

[Robert Kaiser]

FYI, bug 328795 originally introduced it in Thunderbird.

I already worked around it not being there in bug bug 562339 ending up with http://mxr.mozilla.org/comm-central/source/suite/mailnews/mailContextMenus.js#119 - we should probably changes that one to use getBrowser() as well.

Comment 2

[Robert Kaiser]

Attachment: v1: implement it!

This patch is relatively straight-forward, esp. as that caller it adds right now had exactly the same code in use before. :)

Comment 3

[Karsten Düsterloh]

Comment on attachment 467496 [details] [diff] [review]
v1: implement it!

>+// The zoom manager, view source and possibly some other functions still rely
>+// on the getBrowser function.
>+function getBrowser()
>+{
>+  return GetTabMail() ? GetTabMail().getBrowserForSelectedTab() :
>+                        document.getElementById("messagepane");
>+}

Um, getMessageBrowser() exists...

Comment 4

[Robert Kaiser]

(In reply to comment #3)
> Um, getMessageBrowser() exists...

for one thing, it can't replace getBrowser() as toolkit code doesn't know about anything else but getBrowser. For the other, it doesn't take .getBrowserForSelectedTab() into account, from what I see, and Thunderbird switched away from what getMessageBrowser does in bug 495818 because that returned the wrong browser in some cases.

Comment 5

[Ian Neal]

Comment on attachment 467496 [details] [diff] [review]
v1: implement it!

I'd prefer getBrowser function to be in mailWindowOverlay.js, so r=me with that addressed.

Comment 6

[Karsten Düsterloh]

> > Um, getMessageBrowser() exists...
> 
> for one thing, it can't replace getBrowser() as toolkit code doesn't know about
> anything else but getBrowser. For the other, it doesn't take
> .getBrowserForSelectedTab() into account, from what I see, and Thunderbird
> switched away from what getMessageBrowser does in bug 495818 because that
> returned the wrong browser in some cases.

I meant that you should call getMessageBrowser() (or even gMessageBrowser) instead of touching document.getElementById("messagepane") directly.

Comment 7

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/071ee24478ff with Ian's and Karsten's nits addressed.