589114 - Use frame scheduling for animated Fullscreen toolbar hiding

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Thomas Stache]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3) Gecko/20100805 Firefox/4.0
Build Identifier: 

Follow-up according to https://bugzilla.mozilla.org/show_bug.cgi?id=240859#c39

> The animation should be replaced with the new css transition, reducing the
> custom animation code for this fullscreen autohide function.

Reproducible: Always

Comment 1

[Dão Gottwald [:dao]]

Morphing. mozRequestAnimationFrame provides the same benefits as CSS animations but leaves more control to the script.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

more s/FullScreen/this/

Comment 4

[Asa Dotzler [:asa]]

Dao, is there any perf win to be had by moving to CSS or is this just for code maintainability?

Comment 5

[Daniel C]

This is currently the jerkiest of the UI animations for me and I believe that mozRequestAnimationFrame should help with that. Also, this bug has the perf keyword.

I think after 10+ months it's probably time to look for another reviewer.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

updated to tip

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

oops, I didn't pay enough attention when merging

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 585018 [details] [diff] [review]
patch

Review of attachment 585018 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, r=me. i <3 bind().

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2843998a1579

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2843998a1579

Comment 11

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Followup patch

The animation is also cancelled in enterDomFullScreen, which was missed.

If preferred, we can re-close this & just file a followup.

Comment 12

[Dão Gottwald [:dao]]

(In reply to Paul O'Shannessy [:zpao] from comment #11)
> If preferred, we can re-close this & just file a followup.

Please do.