Last Comment Bug 589114 - Use frame scheduling for animated Fullscreen toolbar hiding
: Use frame scheduling for animated Fullscreen toolbar hiding
Status: RESOLVED FIXED
[snappy]
: perf, polish
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: Firefox 12
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on: 240859 717030
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-20 02:40 PDT by Thomas Stache
Modified: 2013-12-27 14:30 PST (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.28 KB, patch)
2010-08-20 22:55 PDT, Dão Gottwald [:dao]
no flags Details | Diff | Splinter Review
patch (4.31 KB, patch)
2010-08-21 02:44 PDT, Dão Gottwald [:dao]
no flags Details | Diff | Splinter Review
patch (4.21 KB, patch)
2011-12-30 12:10 PST, Dão Gottwald [:dao]
no flags Details | Diff | Splinter Review
patch (4.21 KB, patch)
2011-12-30 12:14 PST, Dão Gottwald [:dao]
dietrich: review+
Details | Diff | Splinter Review
Followup patch (3.03 KB, patch)
2012-01-10 11:35 PST, Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
no flags Details | Diff | Splinter Review

Description Thomas Stache 2010-08-20 02:40:19 PDT
User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3) Gecko/20100805 Firefox/4.0
Build Identifier: 

Follow-up according to https://bugzilla.mozilla.org/show_bug.cgi?id=240859#c39

> The animation should be replaced with the new css transition, reducing the
> custom animation code for this fullscreen autohide function.

Reproducible: Always
Comment 1 Dão Gottwald [:dao] 2010-08-20 22:54:36 PDT
Morphing. mozRequestAnimationFrame provides the same benefits as CSS animations but leaves more control to the script.
Comment 2 Dão Gottwald [:dao] 2010-08-20 22:55:24 PDT
Created attachment 468001 [details] [diff] [review]
patch
Comment 3 Dão Gottwald [:dao] 2010-08-21 02:44:51 PDT
Created attachment 468022 [details] [diff] [review]
patch

more s/FullScreen/this/
Comment 4 Asa Dotzler [:asa] 2011-07-03 10:08:19 PDT
Dao, is there any perf win to be had by moving to CSS or is this just for code maintainability?
Comment 5 Daniel Cater 2011-07-03 10:34:34 PDT
This is currently the jerkiest of the UI animations for me and I believe that mozRequestAnimationFrame should help with that. Also, this bug has the perf keyword.

I think after 10+ months it's probably time to look for another reviewer.
Comment 6 Dão Gottwald [:dao] 2011-12-30 12:10:51 PST
Created attachment 585017 [details] [diff] [review]
patch

updated to tip
Comment 7 Dão Gottwald [:dao] 2011-12-30 12:14:21 PST
Created attachment 585018 [details] [diff] [review]
patch

oops, I didn't pay enough attention when merging
Comment 8 Dietrich Ayala (:dietrich) 2012-01-06 10:32:54 PST
Comment on attachment 585018 [details] [diff] [review]
patch

Review of attachment 585018 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, r=me. i <3 bind().
Comment 10 Ed Morley [:emorley] 2012-01-07 19:31:49 PST
https://hg.mozilla.org/mozilla-central/rev/2843998a1579
Comment 11 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-01-10 11:35:36 PST
Created attachment 587407 [details] [diff] [review]
Followup patch

The animation is also cancelled in enterDomFullScreen, which was missed.

If preferred, we can re-close this & just file a followup.
Comment 12 Dão Gottwald [:dao] 2012-01-10 13:18:57 PST
(In reply to Paul O'Shannessy [:zpao] from comment #11)
> If preferred, we can re-close this & just file a followup.

Please do.

Note You need to log in before you can comment on or make changes to this bug.