Bug 589114 missed canceling the animation from enterDomFullScreen.
Created attachment 587466 [details] [diff] [review] Patch v0.1
Comment on attachment 587466 [details] [diff] [review] Patch v0.1 The "sample" method also calls mozCancelAnimationFrame, which is slightly confusing. Can you either use your helper method everywhere, name it in a way that makes it clearer why sample doesn't use it, or just not add that method at all?
Created attachment 587520 [details] [diff] [review] Patch v0.2 Ah, I missed that usage in "sample". I think "cancelAnimation" makes sense, but "endAnimation" or something similar would also work if you don't think cancelAnimation works.
Comment on attachment 587520 [details] [diff] [review] Patch v0.2 _cancelAnimation (underscore added), please
Attachment #587520 - Flags: review?(dao) → review+
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
You need to log in before you can comment on or make changes to this bug.