Closed
Bug 717030
Opened 13 years ago
Closed 13 years ago
Cancel fullscreen animation when entering dom fullscreen
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 12
People
(Reporter: zpao, Assigned: zpao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.50 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Bug 589114 missed canceling the animation from enterDomFullScreen.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #587466 -
Flags: review?(dao)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 587466 [details] [diff] [review] Patch v0.1 The "sample" method also calls mozCancelAnimationFrame, which is slightly confusing. Can you either use your helper method everywhere, name it in a way that makes it clearer why sample doesn't use it, or just not add that method at all?
|
|
Assignee | |
Comment 3•13 years ago
|
||
Ah, I missed that usage in "sample". I think "cancelAnimation" makes sense, but "endAnimation" or something similar would also work if you don't think cancelAnimation works.
Attachment #587466 -
Attachment is obsolete: true
Attachment #587466 -
Flags: review?(dao)
Attachment #587520 -
Flags: review?(dao)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 587520 [details] [diff] [review] Patch v0.2 _cancelAnimation (underscore added), please
Attachment #587520 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/932d5d369d4e
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/932d5d369d4e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
You need to log in
before you can comment on or make changes to this bug.
Description
•