Closed Bug 717030 Opened 8 years ago Closed 8 years ago

Cancel fullscreen animation when entering dom fullscreen

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: zpao, Assigned: zpao)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 589114 missed canceling the animation from enterDomFullScreen.
Comment on attachment 587466 [details] [diff] [review]
Patch v0.1

The "sample" method also calls mozCancelAnimationFrame, which is slightly confusing. Can you either use your helper method everywhere, name it in a way that makes it clearer why sample doesn't use it, or just not add that method at all?
Attached patch Patch v0.2Splinter Review
Ah, I missed that usage in "sample". I think "cancelAnimation" makes sense, but "endAnimation" or something similar would also work if you don't think cancelAnimation works.
Attachment #587466 - Attachment is obsolete: true
Attachment #587466 - Flags: review?(dao)
Attachment #587520 - Flags: review?(dao)
Comment on attachment 587520 [details] [diff] [review]
Patch v0.2

_cancelAnimation (underscore added), please
Attachment #587520 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/932d5d369d4e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
You need to log in before you can comment on or make changes to this bug.