Last Comment Bug 717030 - Cancel fullscreen animation when entering dom fullscreen
: Cancel fullscreen animation when entering dom fullscreen
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 12
Assigned To: Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
:
:
Mentors:
Depends on:
Blocks: 589114
  Show dependency treegraph
 
Reported: 2012-01-10 14:03 PST by Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
Modified: 2012-01-13 02:54 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v0.1 (3.03 KB, patch)
2012-01-10 14:04 PST, Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
no flags Details | Diff | Splinter Review
Patch v0.2 (3.50 KB, patch)
2012-01-10 15:54 PST, Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
dao+bmo: review+
Details | Diff | Splinter Review

Description Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-01-10 14:03:32 PST
Bug 589114 missed canceling the animation from enterDomFullScreen.
Comment 1 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-01-10 14:04:44 PST
Created attachment 587466 [details] [diff] [review]
Patch v0.1
Comment 2 Dão Gottwald [:dao] 2012-01-10 14:17:24 PST
Comment on attachment 587466 [details] [diff] [review]
Patch v0.1

The "sample" method also calls mozCancelAnimationFrame, which is slightly confusing. Can you either use your helper method everywhere, name it in a way that makes it clearer why sample doesn't use it, or just not add that method at all?
Comment 3 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-01-10 15:54:25 PST
Created attachment 587520 [details] [diff] [review]
Patch v0.2

Ah, I missed that usage in "sample". I think "cancelAnimation" makes sense, but "endAnimation" or something similar would also work if you don't think cancelAnimation works.
Comment 4 Dão Gottwald [:dao] 2012-01-11 00:58:27 PST
Comment on attachment 587520 [details] [diff] [review]
Patch v0.2

_cancelAnimation (underscore added), please
Comment 5 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-01-11 11:20:41 PST
https://hg.mozilla.org/integration/fx-team/rev/932d5d369d4e
Comment 6 Tim Taubert [:ttaubert] 2012-01-13 02:54:53 PST
https://hg.mozilla.org/mozilla-central/rev/932d5d369d4e

Note You need to log in before you can comment on or make changes to this bug.