589304 - When tabs are small enough to hide the close icon, stack tabs

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Tony Chung [:tchung]]

Attachment: Tab thumbnail no Close screenshot

The Close option (X), goes away when resizing a tab thumbnail in tabcandy view.   We should either limit the size a tab can be resized to minimum, or keep the Close option always visible.

See screenshot

Repro:
1) install Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre
2) open tabcandy and create a few tabs there
3) hold the bottom right corner of a tab and resize it small
4) Verify the tab thumbnail loses the close (X) after a certain size

Expected:
- keep the close X button around or limit the size of reduction

Actual:
- close X button goes away

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Perhaps in cases when the thumbnail is too small to show it neatly, we can hide it, but then display it again (fade it back in) when we hover over the tab?

Comment 2

[Ian Gilman [:iangilman]]

Below a certain size, thumbnails are so small that the close box would take up almost the entire space, making it difficult to interact with the thumbnail without accidentally closing it. At that size, move and resize are more important than close. 

Perhaps that threshold could be a little lower (allowing thumbnails the size shown in the screen shot to still have close boxes), but we need that cut-off at some point. 

Another possibility is we can tweak the "stack" threshold so that by the time thumbnails are too small for a close box, they stack instead.

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #2)
> Another possibility is we can tweak the "stack" threshold so that by the time
> thumbnails are too small for a close box, they stack instead.

LIKE.

Comment 4

[Aza Raskin [:aza]]

I concur, the solution should be:

> To tweak the "stack" threshold so that by the time thumbnails are
> too small for a close box, they stack instead.

We should also:

* Decrease the size at which the close icon closes.

Comment 5

[Ian Gilman [:iangilman]]

What about orphan tabs? What happens when they get too small?

Comment 6

[Aza Raskin [:aza]]

I don't think orphan tabs are any different; we are removing the close icons so that you don't accidentally close a tab as the clickable area for zooming in is going to zero.

Comment 7

[Aza Raskin [:aza]]

Attachment: Patch v1

* Decreased the size at which tabs lose their close button
* Tweaked the size at which stacks form (although in the end decided to have a state where tabs don't have close buttons using my wishy-washy "felt right" metric)

Comment 8

[Ian Gilman [:iangilman]]

Comment on attachment 477136 [details] [diff] [review]
Patch v1

   shouldStack: function GroupItem_shouldStack(count) {
     if (count <= 1)
       return false;
-
+      

Replacing an empty blank line with one that has spaces in it is frowned upon. 

Otherwise looks good. I don't think this kind of change needs a test.

Comment 9

[Aza Raskin [:aza]]

Attachment: Patch v1.1

Fixed Ian's nit.

Comment 10

[Ian Gilman [:iangilman]]

Comment on attachment 477171 [details] [diff] [review]
Patch v1.1

Reassigning review to dolske while dietrich is jammed up with b7 stuff.

Comment 11

[Justin Dolske [:Dolske]]

Comment on attachment 477171 [details] [diff] [review]
Patch v1.1

>-    return (rects[0].width < TabItems.minTabWidth * 1.35);
>+    return (rects[0].width < 55);

Sorta feels like this should be a constant defined somewhere, but I guess it's fine.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 477171 [details] [diff] [review]
Patch v1.1

a=beltzner

Comment 13

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/c0e4d99aa433

Comment 14

[Tracy Walker [:tracy]]

verified with 20101013 build of minefield  

However there is a bit of shrinking allowed between close button disappearance and stacking.  Is that the wishy-washiness mentioned in comment 7?

Comment 15

[Ian Gilman [:iangilman]]

(In reply to comment #14)
> verified with 20101013 build of minefield  
> 
> However there is a bit of shrinking allowed between close button disappearance
> and stacking.  Is that the wishy-washiness mentioned in comment 7?

Indeed it is.