58966 - one-time leaks in nsLoggingService

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsLoggingService (and related code?) leak, once per session, an
nsObjectHashtable, an nsFileLogEventSink, a PRMonitor, and one nsLog object per
log.  (The last of the 4 classes was removed from the leak stats so that this
wouldn't show up.)

Comment 1

[Bernd]

Attachment: patch

Comment 2

[Bernd]

Couldn't this leak be easily fixed by adding the necessary stuff to the
nsLoggingService::Release method. I do not right undertstand how to free the
mDefaultSink, but I believe it should be freed.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why would deleting stuff in |Release| make sense?

I thought the problem here was that we're assigning things to statics and never
doing anything about them later on.

Comment 4

[dprice (gone)]

I'm adopting all of warren's leaks.

Comment 5

[dprice (gone)]

-> cathleen for a new home

Comment 6

[Asa Dotzler [:asa]]

adding cathleen so she'll know that you want her to find a new home for this bug.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See bug 94480 (and the patch to remove this code).

Comment 8

[Asa Dotzler [:asa]]

->cathleen

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 23717 [details] [diff] [review]
patch

(In reply to comment #7)
> See bug 94480 (and the patch to remove this code).

This file was removed by bug 107510 :-)

Comment 10

[Serge Gautherie (:sgautherie)]

R.Fixed.

David, reopen if I missed something.