Clearing private data should allow for choosing the type of data to clear

NEW
Unassigned

Status

Firefox for Android Graveyard
General
8 years ago
5 years ago

People

(Reporter: Zhu, Junmin, Unassigned)

Tracking

({pp, uiwanted, ux-control})

Trunk
pp, uiwanted, ux-control

Details

(Whiteboard: [testday-2011-06-24])

Attachments

(3 attachments)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8 ( .NET CLR 3.5.30729)
Build Identifier: 2.0a1pre

fennec should support user to clear cookies.

Reproducible: Always

Steps to Reproduce:
1.launch fennec
2.switch to preference panel

Actual Results:  
no button or interact UI to let user clear cookies.

Expected Results:  
there should exist interact UI for user to clear cookies.
(Reporter)

Comment 1

8 years ago
Created attachment 468245 [details] [diff] [review]
patch for provide clear cookies function

Here is a patch, based on mobile tip:af67cbcea09d
I'm not sure we want to add a preference row just for that
I'm not sure we want to add a preference row just for that.

Maybe we could update the "Clear private data" row to have a way to select (menulist?) what to clear (Something similar to what Firefox is doing). when clicking on the "Clear" button.

This solution will have an interesting border side effect of resolving bug 531825 :)
Sorry for comment 2 which is only a part of my full comment, bugzilla was down this morning (GMT)
(Reporter)

Comment 5

8 years ago
at least, fennec should support user to clear the private data respectively, not click on button and clear all of data(history, download, cookies and so on) in one time.
(In reply to comment #5)
> at least, fennec should support user to clear the private data respectively,
> not click on button and clear all of data(history, download, cookies and so on)
> in one time.

I agree on that, that's what I'm trying to say in my comment.
A menulist might not work since it's not multi-select. We would want some way for the user to be able to select or unselect data items.

Maybe a XUL dialog, opened via importDialog?
(In reply to comment #7)
> A menulist might not work since it's not multi-select. We would want some way
> for the user to be able to select or unselect data items.
> 
right

> Maybe a XUL dialog, opened via importDialog?

Works for me.

Zhu, do you want to do it?
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 9

8 years ago
I am in, Do we have design drafts for this?
(In reply to comment #9)
> I am in, Do we have design drafts for this?

No, but something similar to the Firefox "Clear Recent History" popup (but without the little arrow to show/hide the list) should do the trick if you use Fennec dialog style.
Assignee: nobody → wjohnston
(Reporter)

Comment 11

8 years ago
you mean erase the little arrow, and directly show the following check boxes?
(In reply to comment #11)
> you mean erase the little arrow, and directly show the following check boxes?

ell, we prefer simplified UIs in Fennec. So we could imagine a UI that looks like the Sharing popup (Site menu -> Share page) or a context menu popup: A simple list, but a multi-select list. The other examples are single selection lists, so the UI closes when one of the items are tapped.

In the multi-selection UI, we'd need an image to show "selected" and a bottom row/button to allow the user to "Clear" the selected items. Maybe a visual separator between the list items and the "Clear" button. To cancel, the user merely taps outside the list UI to dismiss it.
(Reporter)

Comment 13

8 years ago
(In reply to comment #12)
 
> ell, we prefer simplified UIs in Fennec. So we could imagine a UI that looks
> like the Sharing popup (Site menu -> Share page) or a context menu popup: A
> simple list, but a multi-select list. The other examples are single selection
> lists, so the UI closes when one of the items are tapped.
   
  Because usr may want to clear multi-selection, so I don't think single selection is suitable. I prefer to provide multi-select list as Comfire close pop up, which we can add checkboxs for multi-select.

  What do you think about this?

> In the multi-selection UI, we'd need an image to show "selected" and a bottom
> row/button to allow the user to "Clear" the selected items. Maybe a visual
> separator between the list items and the "Clear" button. To cancel, the user
> merely taps outside the list UI to dismiss it.

  or just provide "Clear" and "Cancel" button at the bottom row?
(In reply to comment #13)

>   Because usr may want to clear multi-selection, so I don't think single
> selection is suitable. I prefer to provide multi-select list as Comfire close
> pop up, which we can add checkboxs for multi-select.
> 
>   What do you think about this?

Yes, a multi-select list is required. Or if we create a custom UI for this, a list of toggles, like in the preference UI:

[Clear History                          ]
[Browsings & Download History (yes | no)]
[Cookies                      (yes | no)]
[Cache                        (yes | no)]
-----------------------------------------
[                  Clear                ]

>   or just provide "Clear" and "Cancel" button at the bottom row?

We don't use "cancel" buttons. Tapping outside the popup is how we dismiss popups. The back button on android is also tied into the dismiss system too.
(Reporter)

Comment 15

8 years ago
(In reply to comment #14)
> Yes, a multi-select list is required. Or if we create a custom UI for this, a
> list of toggles, like in the preference UI:
> 
> [Clear History                          ]
> [Browsings & Download History (yes | no)]
> [Cookies                      (yes | no)]
> [Cache                        (yes | no)]
> -----------------------------------------
> [                  Clear                ]
> 
> >   or just provide "Clear" and "Cancel" button at the bottom row?
> 
> We don't use "cancel" buttons. Tapping outside the popup is how we dismiss
> popups. The back button on android is also tied into the dismiss system too.

That is a good idea, Should we generate new XUL document as share.xul, or integrate it into browser.xul.
I would suggest we generate a new XUL document, like share.xul
Created attachment 471549 [details] [diff] [review]
WIP Patch

Zhu, I had worked on this a little bit before I realized you were on it (doh!).

Here is what I had done. Its not quite what you guys are talking about but it is close. I forgot I was sitting on it, and figured it was better to share than to do nothing with it.
Depends on: 542388
Hardware: x86 → All
Summary: Fennec should support user to clear cookies → Clearing private data should allow for choosing the type of data to clear
No longer depends on: 542388
Duplicate of this bug: 542388
Keywords: pp, ux-control
Created an addon to add this functionality:

https://addons.mozilla.org/en-US/mobile/addon/cleary/
(In reply to comment #14)

> 
> Yes, a multi-select list is required. Or if we create a custom UI for this, a
> list of toggles, like in the preference UI:
> 
> [Clear History                          ]
> [Browsings & Download History (yes | no)]
> [Cookies                      (yes | no)]
> [Cache                        (yes | no)]
  [Active logins                (yes | no)]
  [Form & Search History]       (yes | no)]
  [Time range               (options list)] 
> -----------------------------------------
> [                  Clear                ]
> 

The list from Time range should be displayed the same as Language list for example, and the options should be: Last Hour, Last Two Hours, Today, Everything. What do you think about this?

Updated

7 years ago
Duplicate of this bug: 664440
Should passwords and/or site preferences be added as well?
Passwords can be cleared with the above mentioned add-ons. I don't consider Site prefs part of "private data".
(In reply to comment #24)
> I don't consider Site prefs part of "private data".

The reason they're "private" is that they're effectively a trail of sites that you've visited.

Glancing at the comment 14, it sounds like this is going to be very similar to Desktop Firefox's "Clear Recent History" dialog.  Is there any reason we shouldn't list all the same types of data available for clearing as on Desktop?
agreed! Let's definitely keep this the same as or very similar to Desktop.
Created attachment 541774 [details]
screenshot

Comment 23 was made in regards to trying to keep the ui same as the desktop.  See screenshot.
(In reply to comment #27)
> Comment 23 was made in regards to trying to keep the ui same as the desktop.
> See screenshot.
(In reply to comment #23)
> Should passwords and/or site preferences be added as well?

(Just to clarify -- note that *Passwords* are *not* listed in the desktop UI, as shown in your screenshot.  I'm not that arguing for/against including them, just pointing that out.)
(In reply to comment #28)
> (In reply to comment #27)
> > Comment 23 was made in regards to trying to keep the ui same as the desktop.
> > See screenshot.
> (In reply to comment #23)
> > Should passwords and/or site preferences be added as well?
> 
> (Just to clarify -- note that *Passwords* are *not* listed in the desktop
> UI, as shown in your screenshot.  I'm not that arguing for/against including
> them, just pointing that out.)

Precisely why I filed bug 664440 (which was promptly marked as a dupe). Passwords are a completely separate issue that deserves its own management, just like it has on Desktop.
I do concede the point it's not in the ui, and gphemlsey had filed bug 664440 which was marked as a dup of this.  Which is one of the reasons why I asked about Passwords as well, otherwise passwords would be missed.  So if that's the case should bug 664440 be reopened as not a duplicate?

The point of the picture was site preferences.  I guess I should have clarified.  Thanks gphemsley and dholbert.  :)

(In reply to comment #29)
> (In reply to comment #28)
> > (In reply to comment #27)
> > > Comment 23 was made in regards to trying to keep the ui same as the desktop.
> > > See screenshot.
> > (In reply to comment #23)
> > > Should passwords and/or site preferences be added as well?
> > 
> > (Just to clarify -- note that *Passwords* are *not* listed in the desktop
> > UI, as shown in your screenshot.  I'm not that arguing for/against including
> > them, just pointing that out.)
> 
> Precisely why I filed bug 664440 (which was promptly marked as a dupe).
> Passwords are a completely separate issue that deserves its own management,
> just like it has on Desktop.
> So if that's the case should bug 664440 be reopened as not a duplicate?

IMO no. When/if we implement this UI, we'll follow desktop's direction, but also take into account any other things we want included.
(In reply to comment #31)
> > So if that's the case should bug 664440 be reopened as not a duplicate?
> 
> IMO no. When/if we implement this UI, we'll follow desktop's direction, but
> also take into account any other things we want included.

I should probably also note that I opened that bug as a stop-gap measure. In the meantime between now and implementing this bug, I would like to not have to clear my passwords in order to clear my history/cache. (Although I admit I haven't looked into the add-ons that purport to offer this behavior.)
Whiteboard: [testday-2011-06-24]
This bug has been quiet too long. We still get a lot of requests about better control of private data.

Madhava, Brian, Ian: Any thoughts and/or direction to add here?
Keywords: uiwanted
Duplicate of this bug: 687014
Assignee: wjohnston → nobody
You need to log in before you can comment on or make changes to this bug.