589851 - [Regression] protocol handlers are broken on 8/22 nightly build

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b4pre) Gecko/20100823 Namoroka/4.0b4pre Fennec/2.0a1pre

Steps to Reproduce:
1. Go to lassey.us/proto.html
2. Click on "call me"

Actual Results:
Nothing happens.

Expected Results:
The phone application on the mobile device should launch (i.e. a launch application dialog should pop-up in the browser).

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

this is a regression from bug 588470

Comment 3

[[e-mail]]

Comment on attachment 468392 [details] [diff] [review]
patch

r=dwitte

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

we're gonna take this for alpha 1

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Should this patch have a test, so that it doesn't break again?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed to a1 rel branch: http://hg.mozilla.org/mozilla-central/rev/c4980b518c79

this still needs to land on m-c, so not closing it yet

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/8baac435bd14

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100825 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100825 Namoroka/4.0b5pre Fennec/2.0a1pre


There's litmus testcases for this that need to be updated a bit- 

https://litmus.mozilla.org/show_test.cgi?id=12313
https://litmus.mozilla.org/show_test.cgi?id=12335

Comment 9

[Aakash Desai [:aakashd]]

Also, there's a follow-up bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=590477

Comment 10

[Aakash Desai [:aakashd]]

wip, but here's an update. litmus testcases 

https://litmus.mozilla.org/show_test.cgi?id=12335
https://litmus.mozilla.org/show_test.cgi?id=12313

updated to regression test this bug. Still need to add a few more tests around this bug as well as a test html page that, so we stop using brad's page.

Comment 11

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Can't we write an automated test for this?  Seems like the "no URL handlers fire" thing would be amenable to automation.

Comment 12

[Aakash Desai [:aakashd]]

We can take care of both, redundancy wouldn't be a bad thing here. Unit tests would be great though