589876 - Switch-to-Tab fails to appear for tabs dragged to their own window

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[u279076]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre

This issue was originally brought to my attention via https://litmus.mozilla.org/single_result.cgi?id=290027

When you drag and drop a tab to its own window, it does not appear in Switch-to-Tab results in the awesomebar.

Steps to Reproduce:
1. Open a few tabs with different websites, make one of them digg.com
2. Open a new tab and type "digg" to verify the switch-to-tab result appears
3. Drag the Digg tab to the desktop
4. Go back to the main window
5. In the still open new tab, type "digg"

Result:
The switch-to-tab result no longer appears if the tab is dragged to its own window

Expected:
Switch-to-Tab result should appear for ALL open tabs

Comment 1

[Elmar Ludwig]

Is this the same issue described in bug 583694?

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.0

this should make it, not sure if I can write a simple enough test for it though, maybe I could emulate a detach and then synthesize a drop.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 470632 [details] [diff] [review]
patch v1.0

I think I don't have time right now to write a complicated b-c test for this edge case... would it be fine to take the patch as is? I can eventually file a bug for the test if we feel like it's absolutely needed.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

A test that just calls swapBrowsersAndCloseOther (i.e. does a tab detach programmatically) would be better than nothing, even if it doesn't test the actual dragging code paths, right?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 470632 [details] [diff] [review]
patch v1.0

r=me, but I think adding a test that calls swapBrowsersAndCloseOther to browser_tabMatchesInAwesomebar.js should be doable.

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Added the requested test.

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/3cd6ec7f86ff