Closed
Bug 589878
Opened 13 years ago
Closed 13 years ago
Tabview resources are included with the wrong url
Categories
(Firefox Graveyard :: Panorama, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: glandium, Assigned: glandium)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
1.24 KB,
patch
|
Details | Diff | Splinter Review |
Tabview resources are included with a resource://gre/modules url, while they live in the application, not the GRE.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → mh+mozilla
Attachment #468389 -
Flags: review?(shaver)
Updated•13 years ago
|
Component: Tabbed Browser → TabCandy
QA Contact: tabbed.browser → tabcandy
Comment on attachment 468389 [details] [diff] [review] Patch I'm not a good reviewer for this; trying iangilman. It would be good if you described, though, why this is a problem.
Attachment #468389 -
Flags: review?(shaver) → review?(ian)
Assignee | ||
Comment 3•13 years ago
|
||
> I'm not a good reviewer for this; trying iangilman. It would be good if you
> described, though, why this is a problem.
This is a problem for firefox-on-xulrunner setups, where the application and the GRE directories are not the same.
Comment 4•13 years ago
|
||
Comment on attachment 468389 [details] [diff] [review] Patch Fair enough, if this works better. Adding Dolske for sanity check.
Attachment #468389 -
Flags: review?(ian)
Attachment #468389 -
Flags: review?(dolske)
Attachment #468389 -
Flags: review+
Updated•13 years ago
|
Attachment #468389 -
Flags: review?(dolske) → review?(dietrich)
Updated•13 years ago
|
Attachment #468389 -
Flags: review?(dietrich)
Attachment #468389 -
Flags: review+
Attachment #468389 -
Flags: approval2.0+
Comment 5•13 years ago
|
||
Assignee: mh+mozilla → mitcho
Attachment #468389 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•13 years ago
|
||
I will checkin myself, thank you. (and the user information in your patch for checkin is wrong)
Assignee: mitcho → mh+mozilla
Keywords: checkin-needed
Comment 7•13 years ago
|
||
(In reply to comment #6) > I will checkin myself, thank you. (and the user information in your patch for > checkin is wrong) Oh, thank you. Please correct the user info.
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/eb533d80b036
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Updated•13 years ago
|
Whiteboard: [qa-]
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•