589878 - Tabview resources are included with the wrong url

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Mike Hommey [:glandium]]

Tabview resources are included with a resource://gre/modules url, while they live in the application, not the GRE.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

Comment 2

[Mike Shaver (:shaver emeritus)]

Comment on attachment 468389 [details] [diff] [review]
Patch

I'm not a good reviewer for this; trying iangilman.  It would be good if you described, though, why this is a problem.

Comment 3

[Mike Hommey [:glandium]]

> I'm not a good reviewer for this; trying iangilman.  It would be good if you
> described, though, why this is a problem.

This is a problem for firefox-on-xulrunner setups, where the application and the GRE directories are not the same.

Comment 4

[Ian Gilman [:iangilman]]

Comment on attachment 468389 [details] [diff] [review]
Patch

Fair enough, if this works better.  Adding Dolske for sanity check.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 6

[Mike Hommey [:glandium]]

I will checkin myself, thank you. (and the user information in your patch for checkin is wrong)

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #6)
> I will checkin myself, thank you. (and the user information in your patch for
> checkin is wrong)

Oh, thank you. Please correct the user info.

Comment 8

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/eb533d80b036