590015 - Add add-on to collection autocomplete doesn't only key off add-on names

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

1. Load https://preview.addons.mozilla.org/en-US/firefox/collections/add
2. Type "steph" and wait for the add-on name-matching (you'll see "stephen3000!!!" at the bottom"
3. Keep typing: "stephen" and note that my add-on doesn't appear in the list
4. Now, type "stephen3" and you'll see it

Actual Results:

The instructions claim we key off the add-on name, but it appears we do name + author (?), as "CLOSE TAB BUTTON 3.6 - 3.7a1pre TAB X MODIFIED", which is auto-completed, doesn't match that string at all

Expected Results:

We should match add-on name first, so "stephen" should find/produce "stephen3000!!!" near the top of its list

(Try also "not only we", which is a substring of another add-on, "Not only weather".)

Comment 1

[Jeff Balogh (:jbalogh)]

Ask stephen if you need a translation.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

English can be pretty hard to read sometimes.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

I need a translation.

I understand that it is not to your liking because it queries off other fields of an addon.

But what is your other complaint?

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Searches only the name field now -- but the results won't be alphabetized.  

Alphabetizing makes sense if we search for things that begin with what you are typing.  That would be alright except I think we'd miss a good number of addons in this search... 

with that said try this, it should be a bit nicer.

http://github.com/jbalogh/zamboni/commits/61d8be7

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

My biggest "complaint" was that we keyed off two criteria, and yes, lumped in with that was that it seemed to make the most sense that it be sorted alphabetically, but you guys made good use-cases for the fix here.

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collections/add; better now, indeed.